Do not give array away

polis-vk · Dec 6, 2023 · 6051c0c · 6051c0c
1 parent 3be98c5
commit 6051c0c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/main/java/ru/vk/itmo/reference/ByteArraySegment.java b/src/main/java/ru/vk/itmo/reference/ByteArraySegment.java
@@ -1,7 +1,9 @@
 package ru.vk.itmo.reference;
 
+import java.io.IOException;
 import java.lang.foreign.MemorySegment;
 import java.nio.ByteBuffer;
+import java.util.function.Consumer;
 
 /**
  * Growable buffer with {@link ByteBuffer} and {@link MemorySegment} interface.
@@ -17,8 +19,8 @@ final class ByteArraySegment {
         this.segment = MemorySegment.ofArray(array);
     }
 
-    byte[] array() {
-        return array;
+    void withArray(final ArrayConsumer consumer) throws IOException {
+        consumer.process(array);
     }
 
     MemorySegment segment() {
@@ -40,4 +42,8 @@ void ensureCapacity(final long size) {
         array = new byte[newSize];
         segment = MemorySegment.ofArray(array);
     }
+
+    interface ArrayConsumer {
+        void process(byte[] array) throws IOException;
+    }
 }
diff --git a/src/main/java/ru/vk/itmo/reference/SSTableWriter.java b/src/main/java/ru/vk/itmo/reference/SSTableWriter.java
@@ -105,7 +105,7 @@ private void writeLong(
                 ValueLayout.OfLong.JAVA_LONG_UNALIGNED,
                 0,
                 value);
-        os.write(longBuffer.array());
+        longBuffer.withArray(os::write);
     }
 
     private void writeSegment(
@@ -119,10 +119,11 @@ private void writeSegment(
                 blobBuffer.segment(),
                 0L,
                 size);
-        os.write(
-                blobBuffer.array(),
-                0,
-                (int) size);
+        blobBuffer.withArray(array ->
+                os.write(
+                        array,
+                        0,
+                        (int) size));
     }
 
     /**