61 evalator finish code for lmeh #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove responses not correct or not answered at all. * Kept only those docs_ids filled by all its instances/responses * get_task_manager handles properly the logger into EvaluatePocketNetworkConfigurableTask. * Tokenizer index now include inique=true * Fix metrics in packages/python/lmeh/utils/task_config.py * Save result in mongoDB
* Update Tokenizer_evaluate (by Rawthil) * reconstruct_instances now return result_height and do not raise error when no doc_id
RawthiL
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concludes the Evaluator (hopefully). The main changes can be summarized as:
docs_idsfilled by all itsinstances/responsesare kept. This implies also filtering thosedocs_idsfrom self.dataset[self.eval_split].get_task_managernow initialize properly the logger intoEvaluatePocketNetworkConfigurableTask.'tokenizer'index now includeinique=true.packages/python/lmeh/utils/task_config.py.PocketNetworkMongoDBResultNumericalformat.