Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] embedded Service to be ServiceId #24

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

red-0ne
Copy link
Collaborator

@red-0ne red-0ne commented Sep 12, 2024

Summary

Update Session.Header.Service references to Session.Header.ServiceId to comply with Poktroll updates.

Issue

Poktroll refactored all embedded Service to ServiceId. ShannonSDK is affected by Session.Header.Service change and needs to be updated.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@red-0ne red-0ne requested a review from adshmh September 12, 2024 20:18
@red-0ne red-0ne self-assigned this Sep 12, 2024
@red-0ne red-0ne merged commit 188eb66 into main Sep 12, 2024
6 of 7 checks passed
@red-0ne red-0ne changed the title Refactor/service to [Refactor] embedded Service to be ServiceId Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants