Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Enforce TODO_UPNEXT comments to have an associated username #896

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Oct 28, 2024

Summary

Improve process for TODO_UPNEXT

Goal is to block PRs on this: TODO_UPNEXT: <do something>
Allow PRs on this: TODO_UPNEXT(@olshansk): <do something>

Verification:

Screenshot 2024-10-28 at 5 18 20 PM

Issue

NA

Type of change

Select one or more from the following:

Testing

@Olshansk Olshansk added the infra Infra or tooling related improvements, additions or fixes label Oct 28, 2024
@Olshansk Olshansk added this to the Shannon Quality of Life milestone Oct 28, 2024
@Olshansk Olshansk requested a review from okdas October 28, 2024 19:19
@Olshansk Olshansk self-assigned this Oct 28, 2024
@Olshansk
Copy link
Member Author

@okdas Is there easy way to test this without merging it in?

Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okdas Is there easy way to test this without merging it in?

Yes - this PR can be used for testing. Just add TODO_UPNEXT: to any file.

.github/workflows/reviewdog.yml Outdated Show resolved Hide resolved
@Olshansk Olshansk requested a review from okdas October 28, 2024 20:35
Copy link

gitguardian bot commented Nov 4, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12819930 Triggered Generic Password 203e76d localnet/kubernetes/observability-prometheus-stack.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. 😎

It would be nice if we could modify the comment contents to explain WHY it's complaining and what the author needs to change (i.e. add attribution). Perhaps it's out of scope but I'm wondering if that could be trivially possible via a different "reporter" or something?

(cc @okdas)

@Olshansk Olshansk merged commit 12342f0 into main Nov 5, 2024
10 of 11 checks passed
@Olshansk Olshansk deleted the TODO_UPDATE branch November 5, 2024 15:35
@Olshansk
Copy link
Member Author

Olshansk commented Nov 5, 2024

CCing @okdas and snoozing this email until next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra or tooling related improvements, additions or fixes
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants