-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workflow] Enforce TODO_UPNEXT
comments to have an associated username
#896
Conversation
@okdas Is there easy way to test this without merging it in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okdas Is there easy way to test this without merging it in?
Yes - this PR can be used for testing. Just add TODO_UPNEXT:
to any file.
Co-authored-by: Dima K. <[email protected]>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12819930 | Triggered | Generic Password | 203e76d | localnet/kubernetes/observability-prometheus-stack.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. 😎
It would be nice if we could modify the comment contents to explain WHY it's complaining and what the author needs to change (i.e. add attribution). Perhaps it's out of scope but I'm wondering if that could be trivially possible via a different "reporter" or something?
(cc @okdas)
CCing @okdas and snoozing this email until next week. |
Summary
Improve process for
TODO_UPNEXT
Goal is to block PRs on this:
TODO_UPNEXT: <do something>
Allow PRs on this:
TODO_UPNEXT(@olshansk): <do something>
Verification:
Issue
NA
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting