[C&P] Fix Unbonding slashed suppliers #891
Conversation
red-0ne
added
bug
There was a problem hiding this comment.
Thank you SO MUCH! ❤️
Once this is merged, I'll try to do more load testing shortly to see if we can break the network again.
I'll wait for more input from @Olshansk or @bryanchriswhite — I'm not comfortable signing for such changes yet. 😅
| @@ -273,8 +273,10 @@ func (st *sessionTree) Delete() error { | |||
| // This was intentionally removed to lower the IO load. | |||
| // When the database is closed, it is deleted it from disk right away. | |||
|
|
|||
| if err := st.treeStore.Stop(); err != nil { | |||
| return err | |||
| if st.treeStore != nil { | |||
There was a problem hiding this comment.
Can we add an error log if treeStore == nil?
I think it would be helpful if this condition is reached for whatever reason in the future.
| @@ -273,8 +273,10 @@ func (st *sessionTree) Delete() error { | |||
| // This was intentionally removed to lower the IO load. | |||
| // When the database is closed, it is deleted it from disk right away. | |||
|
|
|||
| if err := st.treeStore.Stop(); err != nil { | |||
| return err | |||
| if st.treeStore != nil { | |||
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 891) |
github-actions
bot
added
devnet
push-image
Summary
This PR fixes a few bugs that were dependent to each other:
@okdas , One case I didn't manage to reproduce is having the application module account go to
0. Please tell me if you encounter it again.Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist