Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Indexer] Integrate pocketdex into Tiltfile #885

Merged
merged 23 commits into from
Oct 24, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Oct 17, 2024

Summary

  • Adds the pocketdex to the tilt environment if it has been cloned to a sibling directory as "pocketdex"

  • Otherwise, if localnet_config.yaml has indexer.enabled and indexer.clone_if_not_present set to true Tilt will clone it to a sibling directory

  • Otherwise a stub service titled "Indexer Disabled" under the "Pocketdex" label group explains what changes need to be made to the localnet_config.yaml:

    image

Running cmd: echo 'Pocketdex indexer disabled. Set `indexer.enabled` to `true` in `localnet_config.yaml` to enable it.'
Pocketdex indexer disabled. Set `indexer.enabled` to `true` in `localnet_config.yaml` to enable it.
Running cmd: echo 'Pocketdex repo not found. Set `clone_if_not_present` to `true` in `localnet_config.yaml` to clone the repo.'
Pocketdex repo not found. Set `clone_if_not_present` to `true` in `localnet_config.yaml` to clone the repo.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic tooling Tooling - CLI, scripts, helpers, off-chain, etc... observability labels Oct 17, 2024
@bryanchriswhite bryanchriswhite self-assigned this Oct 17, 2024
@bryanchriswhite bryanchriswhite linked an issue Oct 17, 2024 that may be closed by this pull request
5 tasks
Tiltfile Outdated Show resolved Hide resolved
Tiltfile Outdated Show resolved Hide resolved
Tiltfile Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Oct 17, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12819930 Triggered Generic Password a24803f localnet/kubernetes/values-pocketdex-postgres.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Tiltfile Outdated Show resolved Hide resolved
@Olshansk
Copy link
Member

@bryanchriswhite What will it take to make this ready for review?

@bryanchriswhite
Copy link
Contributor Author

@Olshansk I want to check for any cleanup that needs to be done in pocketdex#23 and it needs to be merged to main before this can be merged.

Tiltfile Outdated Show resolved Hide resolved
@bryanchriswhite bryanchriswhite marked this pull request as ready for review October 21, 2024 12:18
Tiltfile Outdated Show resolved Hide resolved
Tiltfile Outdated Show resolved Hide resolved
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryanchriswhite Pushed my changes after review + offline discussion in [1].

Requesting changes as a checkpoint for when you need me to take another look at this.

[1] https://discord.com/channels/824324475256438814/1296487759745253408

Tiltfile Outdated Show resolved Hide resolved
tiltfiles/pocketdex.tilt Show resolved Hide resolved
tiltfiles/pocketdex.tilt Outdated Show resolved Hide resolved
tiltfiles/git.tilt Outdated Show resolved Hide resolved
Tiltfile Show resolved Hide resolved
docusaurus/docs/develop/localnet/observability.md Outdated Show resolved Hide resolved
Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've upped Tiltfile game in this repo! :D Now we're going to need to break our main huge Tiltfile into smaller ones. This is great, thank you!

tiltfiles/git.tilt Outdated Show resolved Hide resolved
@bryanchriswhite bryanchriswhite merged commit 96a9d29 into main Oct 24, 2024
10 of 11 checks passed
@bryanchriswhite bryanchriswhite deleted the feat/integrate/pocketdex branch October 24, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
observability on-chain On-chain business logic tooling Tooling - CLI, scripts, helpers, off-chain, etc...
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Tooling] Integrate pocketdex into Tilt
3 participants