-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Indexer] Integrate pocketdex into Tiltfile #885
Conversation
a7922e0
to
e471207
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12819930 | Triggered | Generic Password | a24803f | localnet/kubernetes/values-pocketdex-postgres.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@bryanchriswhite What will it take to make this ready for review? |
@Olshansk I want to check for any cleanup that needs to be done in pocketdex#23 and it needs to be merged to main before this can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryanchriswhite Pushed my changes after review + offline discussion in [1].
Requesting changes as a checkpoint for when you need me to take another look at this.
[1] https://discord.com/channels/824324475256438814/1296487759745253408
b305c10
to
cf64129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've upped Tiltfile
game in this repo! :D Now we're going to need to break our main huge Tiltfile
into smaller ones. This is great, thank you!
Co-authored-by: Daniel Olshansky <[email protected]>
Summary
Adds the pocketdex to the tilt environment if it has been cloned to a sibling directory as "pocketdex"
Otherwise, if
localnet_config.yaml
hasindexer.enabled
andindexer.clone_if_not_present
set totrue
Tilt will clone it to a sibling directoryOtherwise a stub service titled "Indexer Disabled" under the "Pocketdex" label group explains what changes need to be made to the localnet_config.yaml:
Issue
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make docusaurus_start
; only needed if you make doc changesmake go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist