Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Health] refactor: simplify testevents.FilterEvents() #882

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[Code Health] refactor: simplify testevents.FilterEvents() #882

merged 2 commits into from
Oct 15, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Oct 15, 2024 •
edited
Loading

Summary

Remove unnecessary message type URL argument from testutilevents.FilterEvents().

Issue

N/A

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added the code health Cleans up some code label Oct 15, 2024
@bryanchriswhite bryanchriswhite self-assigned this Oct 15, 2024
red-0ne
red-0ne approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great simplification! Thanks for spotting this.

@bryanchriswhite bryanchriswhite merged commit 15cc450 into main Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne red-0ne approved these changes

@Olshansk Olshansk Awaiting requested review from Olshansk

Assignees

@bryanchriswhite bryanchriswhite

Labels
code health Cleans up some code
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Beta TestNet Launch
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanchriswhite @red-0ne