Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoadTesting] Code changes to unblock load testing #819

Closed
wants to merge 7 commits into from

Conversation

okdas
Copy link
Member

@okdas okdas commented Sep 11, 2024

Summary

TBA. It might become a temporary PR.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added testing Test (or test utils) additions, fixes, improvements or other push-image CI related - pushes images to ghcr.io loadtest Work related to load testing labels Sep 11, 2024
@okdas okdas added this to the Shannon Beta TestNet Launch milestone Sep 11, 2024
@okdas okdas self-assigned this Sep 11, 2024
Copy link

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

@okdas
Copy link
Member Author

okdas commented Sep 12, 2024

DO NOT MERGE main branch into issue-742-load-testing.
This has been branched off v0.0.7 to avoid protobuf changes.

Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 819)
Grafana network dashboard for devnet-issue-819

@okdas
Copy link
Member Author

okdas commented Sep 12, 2024

Added caching to avoid round-trips to the pocket RPC node. Tests passed.

Can't figure out why I get:

{"level":"error","service_id":"protocol-anvil","content_length":0,"content_type":"","method":"GET","url":"/?applicationAddr=pokt1pruh7jnjt3hjtjz0y7sund5am7q5v87q86ygvs","rpc_type":"REST","payload":"","application_addr":"pokt1pruh7jnjt3hjtjz0y7sund5am7q5v87q86ygvs","error":"getting current session: address: pokt1pruh7jnjt3hjtjz0y7sund5am7q5v87q86ygvs; serviceId: protocol-anvil; block height: 18426; error: [rpc error: code = Internal desc = grpc: error unmarshalling request: proto: illegal wireType 7]: error while trying to retrieve a session: internal error handling relay request","message":"failed handling relay"}

Doesn't appear to be related to the caching added in the PR.

Even though the branched is created off v0.0.7 release, it appears there's still some discrepancy between new build and the old one.

I'll continue throwing more resources. This will still affect the performance though.

@okdas
Copy link
Member Author

okdas commented Sep 30, 2024

Unlikely to need this as we're moving away from using appgate.
There's a similar functionality will be needed for relayminer, though. Will look into that as I hit that roadblock during the load test.

@okdas okdas closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e loadtest Work related to load testing push-image CI related - pushes images to ghcr.io testing Test (or test utils) additions, fixes, improvements or other
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant