[SessionManager] Skip claims creation if supplier operator balance is too low #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
relayminer
Olshansk
requested changes
Sep 23, 2024
Olshansk
approved these changes
Sep 23, 2024
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 817) |
github-actions
bot
added
devnet
push-image
bryanchriswhite
added a commit
that referenced
this pull request
Sep 24, 2024
… issues/799/tests/params * issues/799/merge/integration-app_x_sup-stake-evts: chore: review feedback improvements [SMST] feat: Use compact SMST proofs (#823) [SessionManager] Skip claims creation if supplier operator balance is too low (#817) chore: self-review improvements # Conflicts: # tests/integration/tokenomics/relay_mining_integration_test.go
bryanchriswhite
added a commit
that referenced
this pull request
Sep 24, 2024
…rge/integration-app_x_transfer-period-base * issues/799/refactor/integration-app: fixup! HEAD^ fix: linter errors chore: review feedback improvements [SMST] feat: Use compact SMST proofs (#823) [SessionManager] Skip claims creation if supplier operator balance is too low (#817) chore: self-review improvements [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815)
bryanchriswhite
added a commit
that referenced
this pull request
Sep 24, 2024
…' into issues/657/chore/app-transfer-period * issues/657/merge/integration-app_x_transfer-period-base: fixup! HEAD^ fix: linter errors chore: review feedback improvements [SMST] feat: Use compact SMST proofs (#823) [SessionManager] Skip claims creation if supplier operator balance is too low (#817) chore: self-review improvements [Code Health] refactor: rename `ApplicationTransfer` msgs (#788) [Docs] Add operations documentation about proof submission fee (#806) [Testing] Fix non-idempotency in (and speed up) supplier staking tests (#815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces filters in the
SubmitClaimsstep to ensure that theSessionManageronly submits claims it can afford to prove.Before each submission, it checks the
SupplierOperatorbalance and filters the claims based on the available funds.Claims are sorted by descending profitability to maximize rewards.
Issue
Since submitting a proof incurs a cost, a
SupplierOperatorwithout sufficient funds would be unable to submit the required proof.This could result in the supplier's stake being slashed if a proof submission is required.
The
SessionManagermust verify that it can afford a proof submission before creating the corresponding claim.Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist