Feat/payable proof submission #780
Conversation
| // an adjustment the current balance to account for the proof submission fee | ||
| // is needed so validateAmountChange can assert on the reward change with the | ||
| // given condition. | ||
| if msgType == "SubmitProof" { |
There was a problem hiding this comment.
I see what you're doing here, but this is a "hidden side effect".
I think you should just either:
- Add a step call
EnsureBalanceIsHighEnoughForProofSubmission
OR - Update the default configs of LocalNet to give everyone high enough balances that this doesn't matter
My preference is (2).
There was a problem hiding this comment.
This is actually not about having enough funds.
It is to make the step Then the account balance of "supplier1" should be "420" uPOKT "more" than before succeed without making it more complicated
fee > reward->lower balanceproof not required->no fee- step needing to know about previous ones
- ...
There's actually an elegant solution without side effect.
Take a snapshot of the balance after the proof submission.
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 780) |
red-0ne
changed the base branch from
feat/proof-submission-fee-param
to
main
…eriod-param' into issues/657/chore/app-transfer-period * pokt/issues/657/refactor/transfer-msg_period-param: chore: review feedback improvements Feat/payable proof submission (#780) [Proof] Proof submission fee param (#779) [Service] Align add service fee param with other params implementation (#778) [Docs] how to create a new release (#783) [Dependencies] Bump go and cosmos-sdk (#797) [Small PR][CI] Add check for stable marshalers (#784)
Summary
This PR implements payable proof submission given the proof submission governance param.
This is a follow-up feature PR to #779 which adds the proof submission governance param.
Issue
Proof messages take up significant block space. We need to deter submitting non-required ones by making proof submission payable by a governance adjusted parameter.
Type of change
Select one or more:
Testing
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist