Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Service] Align add service fee param with other params implementation (
#778) ## Summary This PR refactors the `AddServiceFee` governance parameter to align it with the implementation style of other parameters: * Changed the param type from `uint64` to `Coin`. * Added end-to-end (E2E) tests. * Introduced `UpdateParam` (previously, only `UpdateParams` was available). ## Issue The `AddServiceFee` governance parameter was the first one implemented and did not benefit from improvements made in subsequent governance parameters. Since this is the first and reference implementation for payable messages, it's crucial that it adheres to Poktroll practices for adding governance parameters. _About 2300LOC are auto-generated code and json files_ ## Type of change Select one or more: - [ ] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
- Loading branch information