Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Code review guidelines & learning resources #955

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

Olshansk
Copy link
Member

  • Add GPokT to the main README
  • Add a foundation "code guidelines" only containing examples of comments
  • Add details on tending resolving comments and reviewing PRs
  • Add resources related to trees

@Olshansk Olshansk added the documentation Improvements or additions to documentation label Jul 31, 2023
@Olshansk Olshansk self-assigned this Jul 31, 2023
@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review docs labels Jul 31, 2023
@Olshansk
Copy link
Member Author

Olshansk commented Aug 4, 2023

@red-0ne @0xRampey @dylanlott @h5law Friendly bump on this.

Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olshansk Olshansk merged commit e806500 into main Aug 7, 2023
9 checks passed
@Olshansk Olshansk deleted the docs/code-review-guidelines-olsh-additions branch August 7, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation medium Pull request is medium waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants