Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][Persistence] Adds save and load CLI functions #946

Closed
wants to merge 12 commits into from
Closed

[WIP][Persistence] Adds save and load CLI functions #946

wants to merge 12 commits into from

Conversation

dylanlott
Copy link
Contributor

Description

Adds the CLI for treeStore save and load functionality.

Issue

Fixes #

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jul 28, 2023
@dylanlott dylanlott self-assigned this Jul 28, 2023
@Olshansk
Copy link
Member

@dylanlott Should this be a draft or ready for review?

@dylanlott dylanlott marked this pull request as draft July 29, 2023 01:51
@dylanlott dylanlott changed the base branch from persistence/savepoints-initial to persistence/save-load July 29, 2023 01:52
@reviewpad reviewpad bot added medium Pull request is medium and removed large Pull request is large labels Jul 29, 2023
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Jul 31, 2023
@reviewpad reviewpad bot added medium Pull request is medium large Pull request is large and removed large Pull request is large medium Pull request is medium labels Aug 1, 2023
@dylanlott dylanlott closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dylanlott dylanlott

Labels
large Pull request is large
Projects
V1 Dashboard
Status: Done
Milestone
M2: Pocket DoS (Devnet of Servicers)
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanlott @Olshansk