-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IBC] Add ICS-02 Client Interfaces #932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olshansk
approved these changes
Jul 24, 2023
} | ||
|
||
// PocketClientState defines the ibc client state for Pocket | ||
message PocketClientState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL some stuff from the parametesr in this proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
e2e-devnet-test
Runs E2E tests on devnet
ibc
IBC specific changes
large
Pull request is large
waiting-for-review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 26 Jul 23 09:37 UTC
This pull request includes the following changes:
Makefile:
ibc/client/types/proto/*.proto
andibc/client/light_clients/types/proto/*.proto
files using thePROTOC_SHARED
command.ibc_host_module.go:
IBCHandler
interface.IBCHostSubmodule
interface to only extend theSubmodule
andibcHostFactory
interfaces.ibc_host
constant.GetTimestamp
method.GetProvableStore
method.New file: pocket.proto:
bus_module.go:
New file: wasm.proto:
ibc_client_module.go:
These changes cover updates to Makefile, interface definitions, addition of new files, and modifications to existing files.
Issue
Fixes #894
Type of change
Please mark the relevant option(s):
List of changes
ClientManager
interfaceWASM
client generic types andPocket
specific definitonsTesting
make develop_test
; if any code changes were mademake test_e2e
on k8s LocalNet; if any code changes were madee2e-devnet-test
passes tests on DevNet; if any code was changedRequired Checklist
godoc
format comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)