Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utility] Session Interface - GetSession Implementation (1st iteration) #683

Merged
merged 58 commits into from
Apr 28, 2023

Commits on Apr 11, 2023

  1. Configuration menu
    Copy the full SHA
    c473aea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c0f7269 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Configuration menu
    Copy the full SHA
    11353f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    363f4ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc0f1f5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7eff6f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. All unit tests pasing again

    Olshansk committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    74f11be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f4cbbc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b096bf View commit details
    Browse the repository at this point in the history
  4. Remove read ctx

    Olshansk committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0bf2d75 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Refactor some tests

    Olshansk committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    6c04122 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c913c6d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Configuration menu
    Copy the full SHA
    bfceded View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Configuration menu
    Copy the full SHA
    96fe1a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2eb3c62 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42c59ec View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Configuration menu
    Copy the full SHA
    ee5b3f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50ccff3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    830c72a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    88a36b7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    99b25a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Self review

    Olshansk committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    23f74dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fa7ac3 View commit details
    Browse the repository at this point in the history
  3. Fix one of the broken tests

    Olshansk committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    cc15ba1 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Configuration menu
    Copy the full SHA
    42bc9f6 View commit details
    Browse the repository at this point in the history
  2. Replied to all comments

    Olshansk committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ede4821 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Configuration menu
    Copy the full SHA
    4caac93 View commit details
    Browse the repository at this point in the history
  2. Fix broken test

    Olshansk committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    c723b33 View commit details
    Browse the repository at this point in the history
  3. Merge with main

    Olshansk committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    e108e03 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    32bf680 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8688645 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7df6c88 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Configuration menu
    Copy the full SHA
    50d0c71 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Update utility/session.go

    Co-authored-by: Bryan White <[email protected]>
    Olshansk and bryanchriswhite authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    424cd54 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Bryan White <[email protected]>
    Olshansk and bryanchriswhite authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6c4d3ce View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Update utility/session_test.go

    Co-authored-by: Bryan White <[email protected]>
    Olshansk and bryanchriswhite authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6f26138 View commit details
    Browse the repository at this point in the history
  2. [Makefile] fixes the localnet_db_cli target (#700)

    ## Description
    
    #658 changed how Postgres instances are handled and assigned to
    Validators in the LocalNet, which broke the Make target specified for
    grabbing a shell to the LocalNet database. This PR fixes the command to
    target the Postgres instance for validator-001 by default, since
    validator-001 used for other tasks by default.
    
    ## Type of change
    
    Please mark the relevant option(s):
    
    - [ ] New feature, functionality or library
    - [x] Bug fix
    - [ ] Code health or cleanup
    - [ ] Major breaking change
    - [ ] Documentation
    - [ ] Other
    
    ## List of changes
    
    - Changes `make localnet_db_cli` to target the Postgres instance that
    `validator001` uses.
    
    ## Testing
    
    - [x] `make test_e2e`
    - [x] `make localnet_db_cli` produces a CLI shell to validator001's Postgres
    - [x] `make develop_test`; if any code changes were made
    - [ ] [Docker Compose
    LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
    if any major functionality was changed or introduced
    - [x] [k8s
    LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
    if any infrastructure or configuration changes were made
    
    ## Required Checklist
    
    - [x] I have performed a self-review of my own code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have added, or updated, [`godoc` format
    comments](https://go.dev/blog/godoc) on touched members (see:
    [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
    - [x] I have tested my changes using the available tooling
    - [x] I have updated the corresponding CHANGELOG
    
    ### If Applicable Checklist
    
    - [ ] I have updated the corresponding README(s); local and/or global
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added, or updated,
    [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
    README(s)
    - [ ] I have added, or updated, documentation and
    [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
    if I updated `shared/*`README(s)
    dylanlott authored and Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    547d4b2 View commit details
    Browse the repository at this point in the history
  3. [E2E] adds in-cluster config for E2E tests (#689)

    <!-- REMOVE this comment block after following the instructions
    1. Make the title of the PR is descriptive and follows this format:
    `[<Module>] <DESCRIPTION>`
    2. Update the _Assigness_, _Labels_, _Projects_, _Milestone_ before
    submitting the PR for review.
    3. Add label(s) for the purpose (e.g. `persistence`) and, if applicable,
    priority (e.g. `low`) labels as well.
    -->
    
    Adds In-Cluster configuration support for the cluster-manager so that
    DevNet can run E2E tests.
    
    Related to #582
    
    Please mark the relevant option(s):
    
    - [x] New feature, functionality or library
    - [ ] Bug fix
    - [ ] Code health or cleanup
    - [ ] Major breaking change
    - [x] Documentation
    - [ ] Other <!-- add details here if it a different type of change -->
    
    - Cluster-manager now attempts to use an InCluster config if it can't
    find one at the default `.kube` config location.
    - It uses this configuration to run the E2E tests in DevNet.
    
    - [x] `make develop_test`; if any code changes were made
    - [ ] [Docker Compose
    LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
    if any major functionality was changed or introduced
    - [x] [k8s
    LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
    if any infrastructure or configuration changes were made
    
    <!-- REMOVE this comment block after following the instructions
     If you added additional tests or infrastructure, describe it here.
     Bonus points for images and videos or gifs.
    -->
    
    - [ ] I have performed a self-review of my own code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have added, or updated, [`godoc` format
    comments](https://go.dev/blog/godoc) on touched members (see:
    [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
    - [ ] I have tested my changes using the available tooling
    - [ ] I have updated the corresponding CHANGELOG
    
    - [ ] I have updated the corresponding README(s); local and/or global
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added, or updated,
    [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
    README(s)
    - [ ] I have added, or updated, documentation and
    [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
    if I updated `shared/*`README(s)
    dylanlott authored and Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f3a545e View commit details
    Browse the repository at this point in the history
  4. [Docs] Update shared module creation (#693)

    Incorporates #643 into the shared modules readme.
    
    Fixes #642
    
    Please mark the relevant option(s):
    
    - [ ] New feature, functionality or library
    - [ ] Bug fix
    - [x] Code health or cleanup
    - [ ] Major breaking change
    - [x] Documentation
    - [ ] Other <!-- add details here if it a different type of change -->
    
    - Updates shared module readme
    - Adds `rainTeeFactory` type & compile-time enforcement
    
    - [ ] `make develop_test`; if any code changes were made
    - [ ] [Docker Compose
    LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
    if any major functionality was changed or introduced
    - [ ] [k8s
    LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
    if any infrastructure or configuration changes were made
    
    - [ ] I have performed a self-review of my own code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have added, or updated, [`godoc` format
    comments](https://go.dev/blog/godoc) on touched members (see:
    [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
    - [ ] I have tested my changes using the available tooling
    - [ ] I have updated the corresponding CHANGELOG
    
    - [ ] I have updated the corresponding README(s); local and/or global
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added, or updated,
    [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
    README(s)
    - [ ] I have added, or updated, documentation and
    [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
    if I updated `shared/*`README(s)
    bryanchriswhite authored and Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    efba9a6 View commit details
    Browse the repository at this point in the history
  5. s/actorsToAdds/actorsToAddrs

    Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    673fccb View commit details
    Browse the repository at this point in the history
  6. Updated logger README

    Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    565f0b7 View commit details
    Browse the repository at this point in the history
  7. Add clarifying comments

    Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    5f072f2 View commit details
    Browse the repository at this point in the history
  8. Reply to comments

    Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    aebd770 View commit details
    Browse the repository at this point in the history
  9. Update TECHDEBT ticket

    Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    664abf7 View commit details
    Browse the repository at this point in the history
  10. Merge with main

    Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    4607f7e View commit details
    Browse the repository at this point in the history
  11. Apply demorgan's law

    Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c824948 View commit details
    Browse the repository at this point in the history
  12. Markdown nit

    Olshansk committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    cf2f6e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Update Makefile

    Co-authored-by: Bryan White <[email protected]>
    Olshansk and bryanchriswhite authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d0d3463 View commit details
    Browse the repository at this point in the history
  2. Update utility/session_test.go

    Co-authored-by: Bryan White <[email protected]>
    Olshansk and bryanchriswhite authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    2e92fd2 View commit details
    Browse the repository at this point in the history
  3. [P2P] chore: remove unnecessary stdnetwork package (#703)

    Removes the unneeded `stdnetwork` package.
    
    Covers removal goal of #266. The simplification goal is tracked by #553.
    TLDR; should close #266.
    
    Please mark the relevant option(s):
    
    - [ ] New feature, functionality or library
    - [ ] Bug fix
    - [x] Code health or cleanup
    - [ ] Major breaking change
    - [ ] Documentation
    - [ ] Other <!-- add details here if it a different type of change -->
    
    - Removed unneeded `stdnetwork` package
    - Removed unneeded `use_rain_tree` P2P config field
    
    - [ ] `make develop_test`; if any code changes were made
    - [x] [Docker Compose
    LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
    if any major functionality was changed or introduced
    - [x] [k8s
    LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
    if any infrastructure or configuration changes were made
    
    - [ ] I have performed a self-review of my own code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have added, or updated, [`godoc` format
    comments](https://go.dev/blog/godoc) on touched members (see:
    [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
    - [ ] I have tested my changes using the available tooling
    - [ ] I have updated the corresponding CHANGELOG
    
    - [ ] I have updated the corresponding README(s); local and/or global
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added, or updated,
    [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
    README(s)
    - [ ] I have added, or updated, documentation and
    [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
    if I updated `shared/*`README(s)
    bryanchriswhite authored and Olshansk committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    b83efc7 View commit details
    Browse the repository at this point in the history
  4. [P2P] refactor: rename "network" to "router" (#704)

    ## Description
    
    Refactors everything in the P2P module which previously referred to a
    "network" to instead be thought of as a "router". This begins with the
    `typesP2P.Network` interface and the changes propagates down from there,
    through implementations and into variable names, tests, etc.
    
    ## Issue
    
    Fixes #<issue_number>
    
    ## Type of change
    
    Please mark the relevant option(s):
    
    - [ ] New feature, functionality or library
    - [ ] Bug fix
    - [x] Code health or cleanup
    - [ ] Major breaking change
    - [ ] Documentation
    - [ ] Other <!-- add details here if it a different type of change -->
    
    ## List of changes
    
    - Renamed `Network` interface to `Router`
    - Shortened `Router#NetworkBroadcast` to `#Broadcast`
    - Shortened `Router#NetworkSend` to `#Send`
    - Shortened `Router#networkSendInternal` to `#sendInternal`
    - Shortened `Router#networkBroadcastAtLevel` to `#broadcastAtLevel`
    - Renamed `rainTreeNetwork` to `rainTreeRouter`
    - Renamed `rainTreeNetwork` method receivers
    - Renamed `p2pModule#network` to `#router`
    - Renamed `p2pModule#setupNetwork()` to `#setupRouter()`
    - Renamed config var in `rainTreeRouter#Create`
    - Renamed router logger
    - Renamed `NewRainTreeNetwork()` to `NewRainTreeRouter()`
    - Refactored peers_manager_test.go
    - Refactored network_test.go
    - Simplified p2p module/router config handoff
    - Updated debug logging
    
    ## Testing
    
    - [ ] `make develop_test`; if any code changes were made
    - [ ] [Docker Compose
    LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
    if any major functionality was changed or introduced
    - [ ] [k8s
    LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
    if any infrastructure or configuration changes were made
    
    ## Required Checklist
    
    - [ ] I have performed a self-review of my own code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have added, or updated, [`godoc` format
    comments](https://go.dev/blog/godoc) on touched members (see:
    [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
    - [ ] I have tested my changes using the available tooling
    - [ ] I have updated the corresponding CHANGELOG
    
    ### If Applicable Checklist
    
    - [ ] I have updated the corresponding README(s); local and/or global
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I have added, or updated,
    [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
    README(s)
    - [ ] I have added, or updated, documentation and
    [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
    if I updated `shared/*`README(s)
    bryanchriswhite authored and Olshansk committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c2e2c9a View commit details
    Browse the repository at this point in the history
  5. MInor NIT comments

    Olshansk committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    66a8940 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e26608a View commit details
    Browse the repository at this point in the history
  7. Typo

    Olshansk committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    e4ac25e View commit details
    Browse the repository at this point in the history
  8. Fix changelogs

    Olshansk committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    50b92e5 View commit details
    Browse the repository at this point in the history
  9. Update all the changelogs

    Olshansk committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d06787e View commit details
    Browse the repository at this point in the history
  10. Merge with main

    Olshansk committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    42d69bc View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e2864b8 View commit details
    Browse the repository at this point in the history