-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.17.0 release #615
Merged
3.17.0 release #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When the file picker is used to pick files from an organizational asset library on the SharePoint root site, no files are shown. - Also fix an error in the _parseOrgAssetsLibraryItem function, which causes the absoluteUrl property to lack one / after the root SharePoint URL (e.g. "https://TENANT.sharepoint.comOrganizational Media Library" or "https://TENANT.sharepoint.comsites/OrgAssetsSite/Branding images"). Since this is faulty for org asset libraries on ALL sites, I don't think this property is used, otherwise it would have caused problems already. Explanation of error in file picker of organizational asset library: 1. The relative url of the root site is /, which causes a / to still be present in the library name, after removal of the site relative url. 2. This is turn causes the library name to be an empty string after splitting the library name on /. 3. When building the API request URL for retrieving the organizational assets library items, the library name is therefore missing from the listFullUrl query parameter. - In addition to this, the listFullUrl query parameter can't contain two slashes in front of the library name (also causes the request to fail). - This error would also happen if the site server relative url (_orgAssetsLibraryServerRelativeSiteUrl) starts with a slash.
Fast-serve update to match the most recent changes.
…cker [New Property Control] - PropertyFieldContentTypePicker - Fixes 598
toRelativeUrl returns proper relative url in case of root site
…epicker PropertyFieldFilePicker - add a delete button to the selected file
…org-asset-library Fix root site org asset library showing no items in file picker
added siteAbsoluteUrl to FOlderPicker
* commit changes new control PropertyFieldButton * new Control Button * commit changes new control PropertyFieldButton
* commit changes new control PropertyFieldButton * new Control Button * commit changes new control PropertyFieldButton * commit changes * added Grid control * commit changes * commit changes * added Grid control * commit changes * fix comment add two properties to title and description columns * commit changes * commit change on doc fixed reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
3.17.0 release