Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3353 #3357

Closed
wants to merge 5 commits into from
Closed

Fix 3353 #3357

wants to merge 5 commits into from

Conversation

NishkalankBezawada
Copy link
Contributor

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes #3353

What is in this Pull Request ?

Fix for Issue 3353

Problem statement

Following commands

Get-PnPExternalUser
Disable-PnPSharingForNonOwnersOfSite
Get-PnPSharingForNonOwnersOfSite
Set-PnPTenantSite -DisableSharingForNonOwners
Set-PnPSite -DisableSharingForNonOwners

Throws error as below
image

Solution

image
The highlighted part in the above screen is causing the issue.

changes are done in GetExternalUser.cs, DisableSharingForNonOwnersOfSite.cs, GetSharingForNonOwnersOfSite.cs, SetTenantSite.cs, SetSite.cs has worked when tested.

Test Screens

Get-PnPExternalUser

Fix-Issue-3353

Disable-PnPSharingForNonOwnersOfSite
Get-PnPSharingForNonOwnersOfSite
Set-PnPTenantSite -DisableSharingForNonOwners
Set-PnPSite -DisableSharingForNonOwners

Fix-Issue-3353-2

Summary

copilot:summary

Details

copilot:walkthrough

//Nishkalank

@NishkalankBezawada
Copy link
Contributor Author

Closing the PR since all the commands which are reported to be not working are now working as expected. Tested from my end too.

Thanks,
Nishkalank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Get-PnPExternalUser fails with message "SyntexFeatureLevelOnOff flight is not enabled"
1 participant