feat: implements mace item #6468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KnosTx
reviewed
Oct 30, 2024
| @@ -324,8 +324,9 @@ private function __construct(){ | |||
| public const SPIRE_ARMOR_TRIM_SMITHING_TEMPLATE = 20285; | |||
| public const PITCHER_POD = 20286; | |||
| public const NAME_TAG = 20287; | |||
| public const MACE = 20289; | |||
|
|
|||
jasonw4331
suggested changes
Nov 4, 2024
| @@ -40,5 +40,6 @@ private function __construct(){ | |||
| public const AXE = 1 << 3; | |||
| public const SHEARS = 1 << 4; | |||
| public const HOE = 1 << 5; | |||
| public const MACE = 1 << 6; | |||
There was a problem hiding this comment.
The tool type only must be added here for variants like diamond and iron versions of the item.
|
|
||
| public const FIRST_UNUSED_ITEM_ID = 20288; | ||
| public const FIRST_UNUSED_ITEM_ID = 20290; |
There was a problem hiding this comment.
This file should be autogenerated using the composer script included with pocketmine's build tools.
| use pocketmine\block\BlockToolType; | ||
| use pocketmine\entity\Entity; | ||
|
|
||
| class Mace extends TieredTool { |
There was a problem hiding this comment.
Extending TieredTool implies variants of the tool such as an Iron Mace or Diamond Mace item, which does not exist.
There was a problem hiding this comment.
Yeah, I have ever. In pull request #6446
| @@ -47,6 +48,7 @@ enum ToolTier{ | |||
| case IRON; | |||
| case DIAMOND; | |||
| case NETHERITE; | |||
| case MACE; | |||
There was a problem hiding this comment.
It should be obvious MACE is not a tier which can be applied to existing tools in the game.
jasonw4331
added
Category: Gameplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Added a new weapon class, the Mace, which functions both as a tool and a weapon with specific properties. This implementation includes changes to the item serialization system and new constants to support the Mace.
https://minecraft.wiki/w/Mace
Relevant issues
Changes
API changes
Added API for the Mace weapon in several files, including
ItemSerializerDeserializerRegistrar.phpandItemTypeIds.php.Behavioural changes
Introduced the behaviour of the Mace, which has a 1.5x faster mining rate when used on blocks, and takes damage when attacking entities or breaking blocks.
Backwards compatibility
Screenshot
Note
Don't worry i also implement the compass recovery
Follow-up
Prepare unit tests or in-game playtesting sessions to confirm that the Mace functions as intended.
Caution
What's missing at the moment is item crafting and the main function for calculating damage based on the height of an entity.
I tested this PR by doing the following (tick all that apply):
tests/phpunitfolder)