Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point issue #6467

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

Conversation

GameParrot
Copy link
Contributor

@GameParrot GameParrot commented Oct 7, 2024

Introduction

Fixes blocks not placing right next to the player at certain positions

Relevant issues

Currently you cannot place blocks right next to yourself at some positions due to floating point issues

Changes

API changes

No significant API changes

Behavioural changes

Might affect some extremely precise checks

Backwards compatibility

No Backwards compatibility issues

Tests

I tested this PR by doing the following (tick all that apply):

  • Writing PHPUnit tests (commit these in the tests/phpunit folder)
  • Playtesting using a Minecraft client (provide screenshots or a video)
  • Writing a test plugin (provide the code and sample output)
  • Other (provide details)

Fixes blocks not placing right next to the player at certain positions
@IvanCraft623
Copy link
Member

I'm not seeing the issue, please mention reproduction steps

@GameParrot
Copy link
Contributor Author

GameParrot commented Oct 9, 2024

@dktapps
Copy link
Member

dktapps commented Oct 17, 2024

This function already has an epsilon built in, it shouldn't be needed. Also not clear if this might cause unintended side effects.

@dktapps
Copy link
Member

dktapps commented Oct 20, 2024

Fixes blocks not placing right next to the player at certain positions

Would be nice to have some examples so this can be tested

@joinasau
Copy link

I have exactly the same problem

@jasonw4331 jasonw4331 added Category: Gameplay Related to Minecraft gameplay experience Type: Fix Bug fix, typo fix, or any other fix Status: Insufficiently Tested Status: Unconfirmed Bug has not yet been reproduced by a maintainer labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Status: Insufficiently Tested Status: Unconfirmed Bug has not yet been reproduced by a maintainer Type: Fix Bug fix, typo fix, or any other fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants