-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix floating point issue #6467
base: stable
Are you sure you want to change the base?
Fix floating point issue #6467
Conversation
Fixes blocks not placing right next to the player at certain positions
I'm not seeing the issue, please mention reproduction steps |
Yep, that's the issue Minecraft_2024.09.23_-_12.57.42.12.mp4 |
This function already has an epsilon built in, it shouldn't be needed. Also not clear if this might cause unintended side effects. |
Would be nice to have some examples so this can be tested |
I have exactly the same problem |
Introduction
Fixes blocks not placing right next to the player at certain positions
Relevant issues
Currently you cannot place blocks right next to yourself at some positions due to floating point issues
Changes
API changes
No significant API changes
Behavioural changes
Might affect some extremely precise checks
Backwards compatibility
No Backwards compatibility issues
Tests
I tested this PR by doing the following (tick all that apply):
tests/phpunit
folder)