-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: version command issues #6357
base: stable
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need translation follow up
just added english for now, pmmp/Language#182 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "detailed version" and the general "detail" wording is too vague. Be more specific - this is for restricting access to plugin versions.
Is there some suitable name for this?
|
First one seems the most obvious to me. Don't overthink it. |
that being said, those names look AI generated ... |
for the desc yes 😁 |
Introduction
This pull request is to handle users using the version command for detailed things, such as checking plugin information.
Relevant issues
Fixes #6322
Changes
API changes
Added
DefaultPermissionNames::COMMAND_VERSION_DETAIL
-> Allows the user to view the detailed version of the server.Behavioural changes
Backwards compatibility
Follow-up
Tests
I tested this PR by doing the following (tick all that apply):
tests/phpunit
folder)