Skip to content

Commit

Permalink
Fix github actions failure (#132)
Browse files Browse the repository at this point in the history
* Try installing in editable mode

* Only list dependencies in environment.yml

* Apply new fix to central_latitude argument
  • Loading branch information
jimc101 authored Nov 22, 2023
1 parent 9366e01 commit 85677d4
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pylag-package-conda-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
with:
activate-environment: "pylag_test"
auto-activate-base: false
channels: conda-forge,JimClark
channels: conda-forge
auto-update-conda: true
environment-file: environment.yml
python-version: ${{ matrix.python-version }}
Expand All @@ -27,10 +27,10 @@ jobs:
run: |
conda info
conda list
- name: Install local changes
- name: Install package
shell: bash -l {0}
run: |
python -m pip install .
python -m pip install -e .
# - name: Lint
# shell: bash -l {0}
# run: |
Expand Down
17 changes: 15 additions & 2 deletions environment.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
name: pylag
channels:
- JimClark
- conda-forge
dependencies:
- pylag
- python
- mpi4py
- numpy>=1.20
- scipy>=1.4.1
- cython>=0.29
- progressbar
- natsort
- netCDF4
- cftime>=1.1
- configparser
- stripy
- shapely
- pyproj
- nose2
4 changes: 2 additions & 2 deletions pylag/grid_metrics.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def create_fvcom_grid_metrics_file(fvcom_file_name: str,
variable_names: Optional[dict]={},
obc_file_name: Optional[str]=None,
obc_file_delimiter: Optional[str]=' ',
central_latitude: Optional[float]=0.0,
central_latitude: Optional[int]=0,
grid_metrics_file_name: Optional[str]='./grid_metrics.nc'):
"""Create FVCOM grid metrics file
Expand Down Expand Up @@ -659,7 +659,7 @@ def create_arakawa_a_grid_metrics_file(file_name, lon_var_name='longitude',
reference_var_name=None, bathymetry_var_name=None, dim_names=None,
is_global=False, surface_only=False, save_mask=True, prng_seed=10,
masked_vertices_per_element=0,
central_latitude: Optional[int]=0.0,
central_latitude: Optional[int]=0,
grid_metrics_file_name='./grid_metrics.nc'):
""" Create a Arakawa A-grid metrics file
Expand Down

0 comments on commit 85677d4

Please sign in to comment.