Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use sorted with key func for get_sorted_nodes_edges #471

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

ngynkvn
Copy link
Contributor

@ngynkvn ngynkvn commented Mar 7, 2024

Rather than calling out to a separate function, replace with calls to sorted(.., key=) function, which is faster and part of the standard library.

Wasn't sure what the purpose of obtaining node names were, but if desired we can replicate that behavior with a custom comparison function, and use cmp_to_key to convert to compatible key argument

@ngynkvn ngynkvn changed the title refactor: Use sorted with key func for get_sorted_nodes_edges refactor: Use sorted with key func for get_sorted_nodes_edges Mar 7, 2024
@ngynkvn ngynkvn changed the title refactor: Use sorted with key func for get_sorted_nodes_edges refactor: Use sorted with key func for get_sorted_nodes_edges Mar 7, 2024
@fit-alessandro-berti fit-alessandro-berti merged commit 0b46533 into pm4py:release Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants