Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults control_finding_generator to null to allow Org to manage setting #125

Merged

Conversation

lorengordon
Copy link
Member

No description provided.

@lorengordon lorengordon requested a review from a team August 29, 2023 22:57
@lorengordon lorengordon force-pushed the patch/null-control-finding-generator branch 2 times, most recently from 9222d24 to 78d6724 Compare August 29, 2023 23:11
@lorengordon lorengordon force-pushed the patch/null-control-finding-generator branch from 78d6724 to 6f32268 Compare August 29, 2023 23:55
@lorengordon
Copy link
Member Author

Results of make test:

❯ make test PYTEST_ARGS="-v --nomock"
[bootstrap]: Using external tardigrade-ci, skipping auto-init
[pytest//home/loren/git/repos/tardigrade-ci/tests/terraform_pytest] Starting Python tests found under the directory "/home/loren/git/repos/tardigrade-ci/tests/terraform_pytest"
pytest /home/loren/git/repos/tardigrade-ci/tests/terraform_pytest -v --nomock
============================================================================= test session starts =============================================================================
platform linux -- Python 3.10.11, pytest-7.4.0, pluggy-1.2.0 -- /home/loren/.pyenv/versions/3.10.11/bin/python3.10
cachedir: .pytest_cache
rootdir: /home/loren/git/repos
collected 2 items

../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[securityhub_cross_account] PASSED                                                                                                                                                                                                                             [ 50%]
../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[securityhub_same_account] PASSED                                                                                                                                                                                                                              [100%]

======================================================================== 2 passed in 91.48s (0:01:31) =========================================================================
[pytest//home/loren/git/repos/tardigrade-ci/tests/terraform_pytest]: Tests executed!

@lorengordon lorengordon merged commit aced605 into plus3it:master Aug 30, 2023
4 of 5 checks passed
@lorengordon lorengordon deleted the patch/null-control-finding-generator branch August 30, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants