Please review this change #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems there are a few of these "make it work with Rails3" pull requests stacking up. Any plans to merge these in? This gem is really useful and the lack of Rails 3 support (especially given the relatively simple changes have been contributed already) is frustrating. |
|
+1 |
|
@obrie has indicated in the past that he doesn't have a lot of time to maintain this project. Maybe he can hand it over to someone who does. Like was mentioned earlier, this is a great project and I'm sure lots of people are interested in using it in Rails 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have used this gem before in a spree application and found it very useful.
So, I tried to use it in a rails 3 App and the Preference model could not be found, so I added a rails engine so that the load paths are added etc..
Cheers
Gary