Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #6428 #6479

Closed

Conversation

Rishith-S
Copy link


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #6428

This PR solves the issue not being able to search in sub pages

Screen.Recording.2024-11-08.at.10.47.04.AM.mov

@mister-roboto
Copy link

@Rishith-S you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have already signed the agreement, please allow a week for your agreement to be processed.
Once it is processed, you will receive an email invitation to join the plone GitHub organization as a Contributor.

If after a week you have not received an invitation, then please contact [email protected].

@mister-roboto
Copy link

Eksaq Dev the email address in your commit does not match an email in your GitHub account. Thus it is impossible to determine whether you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have sent in your Plone Contributor Agreement, and received and accepted an invitation to join the Plone GitHub organization, then you might need to either add the email address on your Agreement to your GitHub account or change the email address in your commits. If you need to do the latter, then you should squash the commits with your matching email and push them.

Add more emails to your GitHub account:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

Change the email address in your commits:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit bc007f7
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/672da33e4babec0008588792

@stevepiercy
Copy link
Collaborator

@Rishith-S this is an incorrect implementation. You should first discuss in the original issue the exact problem, and how to best solve it. Closing.

@stevepiercy stevepiercy closed this Nov 8, 2024
@stevepiercy
Copy link
Collaborator

Also do not open multiple PRs for a single issue.

Please read and follow Things not to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search does not work on subpages
3 participants