Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Edit.jsx. #6206

Closed
wants to merge 3 commits into from
Closed

Conversation

BhavishyaSahay
Copy link

Refactored Edit.jsx from class-based component to functional-based component.

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit d2fd133
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66a67e5a469a6900086d0831

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a duplicate of #4959.

@BhavishyaSahay please read and follow First-time contributors, especially Item 2 in Things not to do.

How is this PR different from #4959?

packages/volto/news/6206.feature Outdated Show resolved Hide resolved
@BhavishyaSahay
Copy link
Author

This may be a duplicate of #4959.

@BhavishyaSahay please read and follow First-time contributors, especially Item 2 in Things not to do.

How is this PR different from #4959?

@stevepiercy Sir actually this has been assigned to me as a task for an open source course from my college and I didn't knew that someone has already made the changes before. Please merge it, I'll surely take care of this from the next time and will make sure there is no duplication.

@stevepiercy
Copy link
Collaborator

@BhavishyaSahay sorry, but we expect all contributors to follow our contributing policy. Please direct your instructor to Expectations of first-time contributors. I would be happy to discuss with your instructor why this policy is in place.

If you are a student or learner of Plone, you probably are not a contributor. See the next section, Expectations of first-time contributors, to determine whether you are in fact a contributor.

Closing as duplicate of #4959 because no distinction was given.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file from your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants