Refactored Display.jsx. #6204
Refactored Display.jsx. #6204
Conversation
✅ Deploy Preview for plone-components canceled.
|
|
@FreakForever one of the CI checks failed. I restarted it, as it could be a flaky test. What results did you get from running acceptance tests locally, as described in Code quality? |
|
It looks like this may be a duplicate of #5066. @FreakForever please read Item 2 Things not to do. The last remaining CI check passed. @plone/volto-team this PR is ready for review, if #5066 does not get merged first. |
|
Hey @stevepiercy will this pr get merged ? as in the pr mentioned #5606 some tests are failing. |
|
@FreakForever please read Expectations of first-time contributors, especially the warning. We are all volunteers with limited time, and this issue is very low priority. If this is for a class assignment, then please have your instructor contact me directly. It is unfair to you and volunteers for an instructor to raise unrealistic expectations or make demands. |
|
Sorry for the query, I just wanted to know out of curiosity as it is my
first open source contribution.
…On Tue, Jul 30, 2024, 10:45 PM Steve Piercy ***@***.***> wrote:
@FreakForever <https://github.com/FreakForever> please read Expectations
of first-time contributors
<https://6.docs.plone.org/contributing/first-time.html#expectations-of-first-time-contributors>,
especially the warning.
We are all volunteers with limited time, and this issue is very low
priority.
If this is for a class assignment, then please have your instructor
contact me directly. It is unfair to you and volunteers for an instructor
to raise unrealistic expectations or make demands.
—
Reply to this email directly, view it on GitHub
<#6204 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDI2K5P3OB2P7U2HKT66A7LZO7C3FAVCNFSM6AAAAABLRY4XMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYHAZTGNBUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Closing as a duplicate of #5066. Thanks for your contribution. |
Refactored Display.jsx from class-based component to functional-based component.