Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added download link to filename in file widget #5880

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

sabrina-bongiovanni
Copy link
Contributor

@sabrina-bongiovanni sabrina-bongiovanni commented Mar 14, 2024

Added a UniversalLink tag around the filename to allow users to download the file directly from the widget in other views.
It's useful if a user needs to download the file but didn't create the content and does not have the original file.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit f2ba3bd
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65f435725618b2000832ef03

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit f2ba3bd
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65f4357288384d0008908cbb

@ichim-david
Copy link
Member

@sabrina-bongiovanni you are missing 2 steps that would make this pull request green:

  1. A change log entry within package/volto/news
  2. pnpm test and updating the test snapshot

If you run into any problems get in touch with your colleagues from Redturtle, they are more
than able to help :)

@stevepiercy
Copy link
Collaborator

  • A change log entry within package/volto/news

See Change log entry

  • pnpm test and updating the test snapshot

Testing. Oh, wait, that's not much help. @ichim-david could you work on this issue today? 😁

@ichim-david
Copy link
Member

  • A change log entry within package/volto/news

See Change log entry

  • pnpm test and updating the test snapshot

Testing. Oh, wait, that's not much help. @ichim-david could you work on this issue today? 😁

@stevepiercy plone tune up day, might be a good time todo something about it indeed :)

@sabrina-bongiovanni
Copy link
Contributor Author

@sabrina-bongiovanni you are missing 2 steps that would make this pull request green:

  1. A change log entry within package/volto/news
  2. pnpm test and updating the test snapshot

If you run into any problems get in touch with your colleagues from Redturtle, they are more than able to help :)

Thank you so much. I gave a look at these two topics with Piero and I managed to fix the problems. Let's see if the checks go through correctly this time :)

@pnicolli pnicolli changed the title feat: added download link to filename in file widget Added download link to filename in file widget Mar 15, 2024
@pnicolli
Copy link
Contributor

To further clarify why the expedite PR instead of a discussion on the new feature: it's a feature the Classic UI file widget had in previous plone versions, this just makes it available again.

@ichim-david ichim-david self-requested a review March 16, 2024 06:41
@sneridagh sneridagh merged commit 6b57f7d into plone:main Mar 16, 2024
47 checks passed
sneridagh added a commit that referenced this pull request Apr 16, 2024
* main:
  Add new types generator, don't know why they don't get included when releasing
  Release 18.0.0-alpha.22
  Release @plone/registry 1.5.3
  Cross-package manager Volto path resolver in webpack-relative-resolver (#5893)
  New `volto-update-deps` documentation (#5892)
  Release generate-volto 9.0.0-alpha.13
  Release @plone/scripts 3.6.1
  Improve and fix volto-update-deps (#5889)
  Sort facet values if they are numbers (#5865)
  Release generate-volto 9.0.0-alpha.12
  Bump @plone/scripts and @plone/types to latests (#5888)
  Release 18.0.0-alpha.21
  Release @plone/scripts 3.6.0
  Release @plone/types 1.0.0-alpha.7
  Notify in documentation useLinkedHeadings setting change after changes from #5225 (#5885)
  Add dependencies syncronizer utility (#5879)
  Update volto-slate configuration to indicate it is now part of the core. (#5886)
  Bump all the versions in GitHub workflows (#5873)
  Added download link to filename in file widget (#5880)
  Improve `@plone/types` - Block*Props - Widgets (#5876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants