-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort facet values if they are numbers #5865
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for plone-components canceled.
|
31d14af
to
b8a170a
Compare
b8a170a
to
fe9363e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to factor this out into a named function that can be easily tested?
I have extracted the sorting operation to a function and added some basic tests to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* main: Add new types generator, don't know why they don't get included when releasing Release 18.0.0-alpha.22 Release @plone/registry 1.5.3 Cross-package manager Volto path resolver in webpack-relative-resolver (#5893) New `volto-update-deps` documentation (#5892) Release generate-volto 9.0.0-alpha.13 Release @plone/scripts 3.6.1 Improve and fix volto-update-deps (#5889) Sort facet values if they are numbers (#5865) Release generate-volto 9.0.0-alpha.12 Bump @plone/scripts and @plone/types to latests (#5888) Release 18.0.0-alpha.21 Release @plone/scripts 3.6.0 Release @plone/types 1.0.0-alpha.7 Notify in documentation useLinkedHeadings setting change after changes from #5225 (#5885) Add dependencies syncronizer utility (#5879) Update volto-slate configuration to indicate it is now part of the core. (#5886) Bump all the versions in GitHub workflows (#5873) Added download link to filename in file widget (#5880) Improve `@plone/types` - Block*Props - Widgets (#5876)
Fixes #5864