Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort facet values if they are numbers #5865

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

erral
Copy link
Member

@erral erral commented Mar 10, 2024

Fixes #5864

@erral erral requested a review from iFlameing March 10, 2024 16:22
Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 52b56f7
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65f2c1ce8ee07500080fc01a
😎 Deploy Preview https://deploy-preview-5865--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 52b56f7
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65f2c1ce6741ce0008fedc41

@erral erral force-pushed the erral-sort-non-string-facet-values branch from 31d14af to b8a170a Compare March 10, 2024 16:30
@erral erral force-pushed the erral-sort-non-string-facet-values branch from b8a170a to fe9363e Compare March 10, 2024 16:32
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to factor this out into a named function that can be easily tested?

@erral
Copy link
Member Author

erral commented Mar 11, 2024

I have extracted the sorting operation to a function and added some basic tests to it.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneridagh sneridagh merged commit c8683f0 into main Mar 18, 2024
73 checks passed
@sneridagh sneridagh deleted the erral-sort-non-string-facet-values branch March 18, 2024 11:43
sneridagh added a commit that referenced this pull request Apr 16, 2024
* main:
  Add new types generator, don't know why they don't get included when releasing
  Release 18.0.0-alpha.22
  Release @plone/registry 1.5.3
  Cross-package manager Volto path resolver in webpack-relative-resolver (#5893)
  New `volto-update-deps` documentation (#5892)
  Release generate-volto 9.0.0-alpha.13
  Release @plone/scripts 3.6.1
  Improve and fix volto-update-deps (#5889)
  Sort facet values if they are numbers (#5865)
  Release generate-volto 9.0.0-alpha.12
  Bump @plone/scripts and @plone/types to latests (#5888)
  Release 18.0.0-alpha.21
  Release @plone/scripts 3.6.0
  Release @plone/types 1.0.0-alpha.7
  Notify in documentation useLinkedHeadings setting change after changes from #5225 (#5885)
  Add dependencies syncronizer utility (#5879)
  Update volto-slate configuration to indicate it is now part of the core. (#5886)
  Bump all the versions in GitHub workflows (#5873)
  Added download link to filename in file widget (#5880)
  Improve `@plone/types` - Block*Props - Widgets (#5876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search block configuration breaks when selecting a Catalog index with integer values
3 participants