(Fix): Sorting Order and Sorting On are not working in Search Block edit mode #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dobri1408
changed the title
✅ Deploy Preview for plone-components canceled.
|
… into fix-search-block-state
dobri1408
changed the title
… into fix-search-block-state
|
Hi @sneridagh, the PR is ready for review. In this PR, I have solved the following two problems: if you are on edit, and you have a preexistent search block ( so not created in this instance), and you are clicking on the reversed order, or sort on, the search results are not updated. This is because on the edit, there is a function called onTriggerSearch, that before didn't receive any parameters. I have also included a test. |
tiberiuichim
approved these changes
Feb 28, 2024
avoinea
approved these changes
Mar 7, 2024
|
@dobri1408 I've tested your work and indeed the sorting works now when selecting a sort option. |
|
Hi @ichim-david I have implemented what you have asked. |
|
@sneridagh Can you please take a look on this one and if merge, please backport also to 16.x. Thank you! |
sneridagh
approved these changes
Mar 12, 2024
ichim-david
pushed a commit
that referenced
this pull request
Mar 14, 2024
…dit mode (#5262) Co-authored-by: Claudia Ifrim <[email protected]> Co-authored-by: Alin Voinea <[email protected]>
ichim-david
pushed a commit
that referenced
this pull request
Mar 14, 2024
…dit mode (#5262) Co-authored-by: Claudia Ifrim <[email protected]> Co-authored-by: Alin Voinea <[email protected]>
sneridagh
added a commit
that referenced
this pull request
Mar 14, 2024
* main: (299 commits) Release 18.0.0-alpha.20 Add BBB code for removed WysiwygWidget (#5874) Release 18.0.0-alpha.19 Release @plone/components 2.0.0-alpha.7 Release @plone/slate 18.0.0-alpha.10 Release generate-volto 9.0.0-alpha.11 Release @plone/types 1.0.0-alpha.6 Improve deps in project generator (#5872) Fix broken link to TanStack Query (#5871) Add missing nextjs install step (#5857) (Fix): Sorting Order and Sorting On are not working in Search Block edit mode (#5262) Update docs for defaultBlockType setting (#5862) Add reference to Docker installation for some Linux distributions (#5861) Fix further internal `blocksConfig` pass by reference present in core (related to #5850) (#5859) The proper name is Semantic UI (#5855) Update link to cssnano docs (#5853) [components] Container css (#5849) Do not display options for Site Administrator to create, modify, or delete Manager users (#5244) Fix the introduction of a mutable (referenced) object when assigning … (#5850) Remove draftJS (and related legacy blocks `text`, `table` and `hero`) from core and cleanup dependencies (#5846) ...
sneridagh
added a commit
that referenced
this pull request
Mar 15, 2024
* main: Release 18.0.0-alpha.20 Add BBB code for removed WysiwygWidget (#5874) Release 18.0.0-alpha.19 Release @plone/components 2.0.0-alpha.7 Release @plone/slate 18.0.0-alpha.10 Release generate-volto 9.0.0-alpha.11 Release @plone/types 1.0.0-alpha.6 Improve deps in project generator (#5872) Fix broken link to TanStack Query (#5871) Add missing nextjs install step (#5857) (Fix): Sorting Order and Sorting On are not working in Search Block edit mode (#5262) Update docs for defaultBlockType setting (#5862) Add reference to Docker installation for some Linux distributions (#5861)
sneridagh
pushed a commit
that referenced
this pull request
Mar 18, 2024
…dit mode (#5262) (#5875) Co-authored-by: dobri1408 <[email protected]> Co-authored-by: Claudia Ifrim <[email protected]> Co-authored-by: Alin Voinea <[email protected]>
sneridagh
pushed a commit
that referenced
this pull request
Mar 18, 2024
…dit mode (#5262) (#5878) Co-authored-by: dobri1408 <[email protected]> Co-authored-by: Claudia Ifrim <[email protected]> Co-authored-by: Alin Voinea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screen-capture.webm