Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Navigation #4876

Merged
merged 25 commits into from
Sep 11, 2023
Merged

Refactor Navigation #4876

merged 25 commits into from
Sep 11, 2023

Conversation

Tishasoumya-02
Copy link
Contributor

@Tishasoumya-02 Tishasoumya-02 commented Jun 15, 2023 •
edited
Loading

@netlify
Copy link

netlify bot commented Jun 15, 2023 •
edited
Loading

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 6de80f7
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64e78024d15bc5000845480b

@cypress
Copy link

cypress bot commented Jun 15, 2023 •
edited
Loading

Passing run #6998 ↗︎

0 561 20 0 Flakiness 0

Details:

Merge branch 'master' into navigation-refactor
Project: Volto Commit: 6de80f7c85
Status: Passed Duration: 13:50 💡
Started: Aug 24, 2023 4:10 PM Ended: Aug 24, 2023 4:24 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

sneridagh
sneridagh requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes. Let me thing about the dispatches.

src/hooks/intl/useLang.js Outdated Show resolved Hide resolved
src/hooks/intl/useLang.js Outdated Show resolved Hide resolved
@Tishasoumya-02 Tishasoumya-02 requested review from nileshgulia1 and removed request for nileshgulia1 June 26, 2023 07:56
@JeffersonBledsoe JeffersonBledsoe mentioned this pull request Jul 8, 2023
Open
93 tasks
@sneridagh sneridagh merged commit bed71f5 into master Sep 11, 2023
37 checks passed
@sneridagh sneridagh deleted the navigation-refactor branch September 11, 2023 14:25
@wesleybl wesleybl mentioned this pull request Sep 12, 2023
Closed
sneridagh added a commit that referenced this pull request Sep 12, 2023
@sneridagh
Merge branch 'master' into typescript-support-in-core
87fe504 
* master:
  Fix use of CSS modules in webpack 5 (#5165)
  fix back button on search block to update the search results for #4402 (#4879)
  Fix toc accessibility issue (#5058)
  Add external className to UniversalLink for external link. (#5110)
  Refactor Login (#4933)
  Refactor Messages (#4926)
  Refactor Navigation (#4876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nileshgulia1 nileshgulia1 nileshgulia1 approved these changes

@sneridagh sneridagh sneridagh approved these changes

@JeffersonBledsoe JeffersonBledsoe Awaiting requested review from JeffersonBledsoe

Assignees
No one assigned
Labels
24 status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tishasoumya-02 @sneridagh @nileshgulia1