Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Password Reset #4865

Closed
wants to merge 11 commits into from
Closed

Conversation

Tishasoumya-02
Copy link
Contributor

@Tishasoumya-02 Tishasoumya-02 commented Jun 13, 2023

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 551e356
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64905d41b36d2100081b18d9

@cypress
Copy link

cypress bot commented Jun 13, 2023

Passing run #5762 ↗︎

0 503 20 0 Flakiness 0

Details:

remove error
Project: Volto Commit: c68fe85ec5
Status: Passed Duration: 13:54 💡
Started: Jun 19, 2023 1:11 PM Ended: Jun 19, 2023 1:25 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

loaded: PropTypes.bool.isRequired,
error: PropTypes.string,
token: PropTypes.string.isRequired,
setInitialPassword: PropTypes.func.isRequired,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary proptype.

}
}
useEffect(() => {
setisSuccessful(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setisSuccessful(true);
if( loaded)
setisSuccessful(true);

@Tishasoumya-02 Tishasoumya-02 deleted the password-reset-refactor branch June 19, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants