Logout Refactor #4860
Logout Refactor #4860
Conversation
✅ Deploy Preview for volto canceled.
|
Passing run #6937 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Tishasoumya-02
requested review from
sneridagh,
nileshgulia1 and
JeffersonBledsoe
There was a problem hiding this comment.
@Tishasoumya-02 Could we get a test/ include as part of one of the tests you have written already a check for the returnUrl feature of this component?
|
Sorry @JeffersonBledsoe , I am not able to understand |
@Tishasoumya-02 Your current code looks like this: useEffect(() => {
dispatch(logout());
dispatch(purgeMessages());
});This code means that the effect will run every time the component renders (more info in the React docs for useEffect). You probably want something like this which has the array of dependencies for the effect: useEffect(() => {
dispatch(logout());
dispatch(purgeMessages());
}, [dispatch]);While it's unlikely that this component will be around long enough for the effect to run multiple times, it is a possibility(and is even something React will do in dev mode). |
… logout-refactor
… logout-refactor
src/hooks/userSession/useToken.js
Outdated
| * @export | ||
| * @return {{ token }} | ||
| */ | ||
| export function useToken() { |
There was a problem hiding this comment.
@Tishasoumya-02 Where is this useToken used?
There was a problem hiding this comment.
I see you are accessing directly from redux state in your component. We can remove this!
There was a problem hiding this comment.
Yes sure, I might have missed it
src/hooks/userSession/useToken.js
Outdated
| * @export | ||
| * @return {{ token }} | ||
| */ | ||
| export function useToken() { |
There was a problem hiding this comment.
I see you are accessing directly from redux state in your component. We can remove this!
* master: (25 commits) (feat):Update toc block entries (#5146) view cypress test (#5149) fix search block search results number (#5171) fix : RecursiveWidget is incorrectly translated (#4513) Bugfix : Responsive Error in login page (#4309) Fix default template for content type which contains block with schem… (#5159) Updated Spanish translation (#5120) ContentRules add and edit forms for languages other than English (#5162) Fix SelectWidget throwing error when editing a recently created conte… (#5155) Don't show ``No value`` option in SelectWidget and ArrayWidget if default value is 0 (#5152) Fix storybook config for project generator. Add support for SCSS, upgrade to webpack 5 in there as well. (#5132) Fix linkcheckbroken 301 redirect to https://www.dlr.de/de (#5131) Release 17.0.0-alpha.25 fix: Fix querystringResults subrequests id, to work properly in dupli… (#5071) Fix accessibility of the content folder buttons (#5101) Refactor Comment (#4874) Refactor Search Tags (#4873) Logout Refactor (#4860) Add www.dlr.de to README (#5112) Fix default toc renderer for nested entries (#5116) ...
* master: (59 commits) (feat):Update toc block entries (#5146) view cypress test (#5149) fix search block search results number (#5171) fix : RecursiveWidget is incorrectly translated (#4513) Bugfix : Responsive Error in login page (#4309) Fix default template for content type which contains block with schem… (#5159) Updated Spanish translation (#5120) ContentRules add and edit forms for languages other than English (#5162) Fix SelectWidget throwing error when editing a recently created conte… (#5155) Don't show ``No value`` option in SelectWidget and ArrayWidget if default value is 0 (#5152) Fix storybook config for project generator. Add support for SCSS, upgrade to webpack 5 in there as well. (#5132) Fix linkcheckbroken 301 redirect to https://www.dlr.de/de (#5131) Release 17.0.0-alpha.25 fix: Fix querystringResults subrequests id, to work properly in dupli… (#5071) Fix accessibility of the content folder buttons (#5101) Refactor Comment (#4874) Refactor Search Tags (#4873) Logout Refactor (#4860) Add www.dlr.de to README (#5112) Fix default toc renderer for nested entries (#5116) ...
#4460