Merge branch 'main' into rr7

* main: Release 18.0.3 Release @plone/registry 2.1.2 Preparing for 18.0.3 Fix weird issue in images build with typings (#6471) Release 18.0.2 Release @plone/providers 1.0.0-alpha.5 Release @plone/scripts 3.8.1 Release @plone/components 2.1.1 Fix packaging and plone/components src export (#6470) Release @plone/registry 2.1.1 Repackage registry Release 18.0.1 Release @plone/providers 1.0.0-alpha.4 Release @plone/components 2.1.0 Release @plone/client 1.0.0-alpha.20 Release @plone/scripts 3.8.0 Release @plone/registry 2.1.0 Get rid of all appearances of parcel in core. (#6469) Replace parcel with tsup. Better types, better tsconfig. Move to ESM. (#6468)
plone · Nov 5, 2024 · b2cc5e8 · b2cc5e8
2 parents 767e998 + 0a7bd48
commit b2cc5e8
Show file tree

Hide file tree

Showing 47 changed files with 251 additions and 1,366 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -56,6 +56,7 @@ const config = {
       ],
       rules: {
         '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/ban-ts-comment': 0,
       },
     },
     {

diff --git a/.gitignore b/.gitignore
@@ -72,6 +72,4 @@ docs/_build/
 /.tool-versions
 docs/source/news
 
-.turbo
-.parcel-cache/
 tsconfig.tsbuildinfo
diff --git a/.npmrc b/.npmrc
@@ -3,4 +3,3 @@ public-hoist-pattern[]=*prettier*
 public-hoist-pattern[]=*stylelint*
 public-hoist-pattern[]=*cypress*
 public-hoist-pattern[]=*process*
-public-hoist-pattern[]=*parcel*
diff --git a/docs/source/release-notes/index.md b/docs/source/release-notes/index.md
@@ -17,9 +17,34 @@ myst:
 
 <!-- towncrier release notes start -->
 
-## 18.0.0 (2024-10-31)
+## 18.0.3 (2024-11-05)
+
+### Bugfix
+
+- Fixed image generation because of a bug in the docker build with registry typings. @sneridagh [#6471](https://github.com/plone/volto/issues/6471)
+
+## 18.0.2 (2024-11-05)
 
-## 18.0.0 (Unreleased)
+### Internal
+
+- Fix missing export src in @plone/components Also improve packaging in packages. @sneridagh [#6470](https://github.com/plone/volto/issues/6470)
+
+## 18.0.1 (2024-11-05)
+
+### Bugfix
+
+- Fix ERR_REQUIRE from ESM module requiring CJS module in `@plone/registry` fix tests. @sneridagh [#6458](https://github.com/plone/volto/issues/6458)
+
+### Internal
+
+- Improve exports in @plone/registry, adapt the Jest test setup. @sneridagh [#6461](https://github.com/plone/volto/issues/6461)
+- Removed `parcel` completely from core. @sneridagh [#6469](https://github.com/plone/volto/issues/6469)
+
+### Documentation
+
+- Fix display of nvm version when installing it for Contributing to Volto. @stevepiercy [#6460](https://github.com/plone/volto/issues/6460)
+
+## 18.0.0 (2024-10-31)
 
 (Summary)
 

diff --git a/package.json b/package.json
@@ -31,8 +31,6 @@
     "update:browserlist": "pnpm --filter @plone/volto add caniuse-lite && pnpm --filter @plone/volto remove caniuse-lite"
   },
   "devDependencies": {
-    "@parcel/packager-ts": "^2.12.0",
-    "@parcel/transformer-typescript-types": "^2.12.0",
     "concurrently": "^8.2.2",
     "husky": "9.0.11",
     "lint-staged": "15.2.2",

diff --git a/packages/blocks/.npmignore b/packages/blocks/.npmignore
@@ -2,7 +2,5 @@ news
 towncrier.toml
 .changelog.draft
 node_modules/
-.parcel-cache
-.parcelrc
 .release-it.json
 .eslintrc.js
diff --git a/packages/blocks/package.json b/packages/blocks/package.json
@@ -29,11 +29,6 @@
     "access": "public"
   },
   "main": "src/index.ts",
-  "targets": {
-    "main": {
-      "includeNodeModules": false
-    }
-  },
   "scripts": {
     "test": "vitest",
     "dry-release": "release-it --dry-run",
@@ -52,13 +47,10 @@
   },
   "dependencies": {},
   "devDependencies": {
-    "@parcel/packager-ts": "^2.12.0",
-    "@parcel/transformer-typescript-types": "^2.12.0",
     "@plone/registry": "workspace:*",
     "@plone/types": "workspace:*",
     "@types/react": "^18",
     "@types/react-dom": "^18",
-    "parcel": "^2.12.0",
     "release-it": "17.1.1",
     "tsconfig": "workspace:*",
     "typescript": "^5.6.3",

diff --git a/packages/client/CHANGELOG.md b/packages/client/CHANGELOG.md
@@ -8,6 +8,13 @@
 
 <!-- towncrier release notes start -->
 
+## 1.0.0-alpha.20 (2024-11-05)
+
+### Internal
+
+- Bump local `typescript` version. @sneridagh [#6461](https://github.com/plone/volto/pull/6461)
+- Replace `parcel` with `tsup`. @sneridagh [#6466](https://github.com/plone/volto/pull/6466)
+
 ## 1.0.0-alpha.19 (2024-10-18)
 
 ### Feature

diff --git a/packages/client/news/6461.internal b/packages/client/news/6461.internal
diff --git a/packages/client/news/6466.internal b/packages/client/news/6466.internal
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -8,7 +8,7 @@
     }
   ],
   "license": "MIT",
-  "version": "1.0.0-alpha.19",
+  "version": "1.0.0-alpha.20",
   "repository": {
     "type": "git",
     "url": "[email protected]:plone/volto.git"

diff --git a/packages/components/.gitignore b/packages/components/.gitignore
@@ -12,5 +12,3 @@ lib
 !.yarn/releases
 !.yarn/sdks
 !.yarn/versions
-
-.parcel-cache/
diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -8,6 +8,18 @@
 
 <!-- towncrier release notes start -->
 
+## 2.1.1 (2024-11-05)
+
+### Internal
+
+- Improve packaging and bring back the export for `src` folder. @sneridagh 
+
+## 2.1.0 (2024-11-05)
+
+### Internal
+
+- Replace `parcel` with `tsup`. Better types, better tsconfig. Move to ESM. @sneridagh [#6467](https://github.com/plone/volto/issues/6467)
+
 ## 2.0.0 (2024-10-31)
 
 ### Internal

diff --git a/packages/components/news/6467.internal b/packages/components/news/6467.internal
diff --git a/packages/components/package.json b/packages/components/package.json
@@ -8,7 +8,7 @@
     }
   ],
   "license": "MIT",
-  "version": "2.0.0",
+  "version": "2.1.1",
   "repository": {
     "type": "git",
     "url": "http://github.com/plone/components.git"
@@ -29,7 +29,8 @@
       "import": "./dist/index.js",
       "default": "./dist/index.cjs"
     },
-    "./dist/*.css": "./dist/*.css"
+    "./dist/*.css": "./dist/*.css",
+    "./src/*": "./src/*"
   },
   "homepage": "https://plone.org",
   "keywords": [

diff --git a/packages/helpers/package.json b/packages/helpers/package.json
@@ -29,14 +29,9 @@
     "access": "public"
   },
   "main": "src/index.ts",
-  "targets": {
-    "main": {
-      "includeNodeModules": false
-    }
-  },
   "scripts": {
-    "watch": "parcel watch",
-    "build": "parcel build",
+    "watch": "tsup",
+    "build": "tsup",
     "test": "vitest",
     "dry-release": "release-it --dry-run",
     "release": "release-it",
@@ -54,14 +49,12 @@
   },
   "dependencies": {},
   "devDependencies": {
-    "@parcel/packager-ts": "^2.12.0",
-    "@parcel/transformer-typescript-types": "^2.12.0",
     "@plone/types": "workspace:*",
     "@types/react": "^18",
     "@types/react-dom": "^18",
-    "parcel": "^2.12.0",
     "release-it": "^17.1.1",
     "tsconfig": "workspace:*",
+    "tsup": "^8.3.5",
     "typescript": "^5.6.3",
     "vitest": "^2.1.3"
   }

diff --git a/packages/providers/.npmignore b/packages/providers/.npmignore
@@ -2,7 +2,5 @@ news
 towncrier.toml
 .changelog.draft
 node_modules/
-.parcel-cache
-.parcelrc
 .release-it.json
 .eslintrc.js
diff --git a/packages/providers/.parcelrc b/packages/providers/.parcelrc
diff --git a/packages/providers/CHANGELOG.md b/packages/providers/CHANGELOG.md
@@ -8,6 +8,19 @@
 
 <!-- towncrier release notes start -->
 
+## 1.0.0-alpha.5 (2024-11-05)
+
+### Internal
+
+- Improve packaging. @sneridagh 
+
+## 1.0.0-alpha.4 (2024-11-05)
+
+### Internal
+
+- Bump local `typescript` version. @sneridagh [#6461](https://github.com/plone/volto/issues/6461)
+- Replace `parcel` with `tsup`. Better types, better tsconfig. Move to ESM. @sneridagh [#6468](https://github.com/plone/volto/issues/6468)
+
 ## 1.0.0-alpha.3 (2024-10-18)
 
 ## 1.0.0-alpha.2 (2024-10-18)

diff --git a/packages/providers/news/6461.internal b/packages/providers/news/6461.internal
diff --git a/packages/providers/package.json b/packages/providers/package.json
@@ -9,7 +9,7 @@
   ],
   "funding": "https://github.com/sponsors/plone",
   "license": "MIT",
-  "version": "1.0.0-alpha.3",
+  "version": "1.0.0-alpha.5",
   "repository": {
     "type": "git",
     "url": "https://github.com/plone/volto.git"
@@ -28,22 +28,23 @@
   "publishConfig": {
     "access": "public"
   },
-  "source": "./src/index.ts",
-  "main": "./dist/main.js",
-  "module": "./dist/module.mjs",
-  "types": "./dist/index.d.ts",
+  "type": "module",
+  "files": [
+    "dist",
+    "README.md"
+  ],
+  "main": "./dist/index.js",
   "exports": {
+    "./package.json": "./package.json",
     ".": {
-      "types": "./dist/index.d.ts",
-      "import": "./dist/module.mjs",
-      "require": "./dist/main.js"
-    },
-    "./src/*": "./src/*"
+      "import": "./dist/index.js",
+      "default": "./dist/index.cjs"
+    }
   },
   "scripts": {
-    "watch": "parcel watch",
-    "build": "parcel build",
-    "build:force": "rm -rf dist && parcel build --no-cache",
+    "build": "tsup",
+    "build:force": "tsup",
+    "check:exports": "attw --pack .",
     "test": "vitest",
     "dry-release": "release-it --dry-run",
     "release": "release-it",
@@ -67,18 +68,13 @@
     "react-aria-components": "^1.4.0"
   },
   "devDependencies": {
-    "@parcel/config-default": "^2.12.0",
-    "@parcel/core": "^2.12.0",
-    "@parcel/packager-ts": "^2.12.0",
-    "@parcel/transformer-js": "^2.12.0",
-    "@parcel/transformer-react-refresh-wrap": "^2.12.0",
-    "@parcel/transformer-typescript-types": "^2.12.0",
+    "@arethetypeswrong/cli": "^0.16.4",
     "@plone/types": "workspace:*",
     "@types/react": "^18",
     "@types/react-dom": "^18",
-    "parcel": "^2.12.0",
     "release-it": "17.1.1",
     "tsconfig": "workspace:*",
+    "tsup": "^8.3.5",
     "typescript": "^5.6.3",
     "vitest": "^2.1.3"
   }

diff --git a/packages/providers/src/AppRouter.tsx b/packages/providers/src/AppRouter.tsx
@@ -1,4 +1,9 @@
-import React, { createContext, ReactNode, useContext, useMemo } from 'react';
+import React, {
+  createContext,
+  type ReactNode,
+  useContext,
+  useMemo,
+} from 'react';
 import { RouterProvider } from 'react-aria-components';
 import { flattenToAppURL as defaultFlattenToAppURL } from './utils';
 
@@ -17,7 +22,7 @@ interface AppRouter {
   useLocation: () => Location | undefined;
   useParams: (opts?: any) => Record<string, string>;
   navigate: (path: string) => void;
-  useHref: (to: string, options?: any) => string;
+  useHref?: (to: string, options?: any) => string;
   flattenToAppURL: (path: string | undefined) => string | undefined;
 }
 

diff --git a/packages/providers/src/PloneProvider.tsx b/packages/providers/src/PloneProvider.tsx
@@ -1,23 +1,26 @@
-import React, { createContext, ReactNode, useContext, useMemo } from 'react';
+import React, {
+  createContext,
+  type ReactNode,
+  useContext,
+  useMemo,
+} from 'react';
 import { QueryClient } from '@tanstack/react-query';
-import { AppRouterProvider, Location } from './AppRouter';
+import { AppRouterProvider, type Location } from './AppRouter';
 import { PloneClientProvider } from './PloneClient';
 import PloneClient from '@plone/client';
 import { flattenToAppURL as defaultFlattenToAppURL } from './utils';
 
 interface PloneProvider {
-  ploneClient: InstanceType<typeof PloneClient>;
-  queryClient: QueryClient;
+  ploneClient?: InstanceType<typeof PloneClient>;
+  queryClient?: QueryClient;
   useLocation: () => Location | undefined;
   useParams: (opts?: any) => Record<string, string>;
   navigate: (path: string) => void;
-  useHref: (to: string, options?: any) => string;
+  useHref?: (to: string, options?: any) => string;
   flattenToAppURL: (path: string | undefined) => string | undefined;
 }
 
 const PloneProviderContext = createContext<PloneProvider>({
-  ploneClient: null,
-  queryClient: null,
   useLocation: () => ({
     href: '',
     pathname: '',

diff --git a/packages/providers/tsconfig.json b/packages/providers/tsconfig.json
@@ -1,6 +1,27 @@
 {
-  "extends": "tsconfig/react-library.json",
-  "include": ["src", "src/**/*.js"],
+  "compilerOptions": {
+    "esModuleInterop": true,
+    "skipLibCheck": true,
+    "target": "es2022",
+    "allowJs": true,
+    "resolveJsonModule": true,
+    "moduleDetection": "force",
+    "isolatedModules": true,
+    "verbatimModuleSyntax": true,
+
+    "strict": true,
+    "noImplicitOverride": true,
+
+    "lib": ["es2022", "dom", "dom.iterable"],
+    "module": "preserve",
+    "noEmit": true,
+
+    "jsx": "react-jsx",
+
+    "allowSyntheticDefaultImports": true,
+    "forceConsistentCasingInFileNames": true
+  },
+  "include": ["src"],
   "exclude": [
     "node_modules",
     "build",