Skip to content

Commit

Permalink
The proper name is Semantic UI (#5855)
Browse files Browse the repository at this point in the history
  • Loading branch information
stevepiercy authored Mar 7, 2024
1 parent 90c7320 commit 7bc30cb
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
6 changes: 3 additions & 3 deletions docs/source/addons/theme.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ THEME='volto-my-theme' yarn start

## Using your own theming escape hatch

Volto theming uses SemanticUI theming capabilities to define and extend a theme for your site.
Volto theming uses Semantic UI theming capabilities to define and extend a theme for your site.
However, while maintaining and playing well with the Semantic UI Volto base, using a traditional CSS approach can be done using the LESS preprocessor-based `extras` escape hatch.

At the same time, one can either discard or complement the extras escape hatch and add your own, by customizing the `theme.js` module in Volto.
Expand Down Expand Up @@ -168,10 +168,10 @@ However, there is a problem with this approach.
You cannot use existing theme variables, including breakpoints, on these new styles.
Similarly, it gets somewhat detached from the normal flow of the loaded theme.
The same applies for add-ons, as they are detached from the current theme.
One could use a SemanticUI approach for making this work, but it's SemanticUI bound.
One could use a Semantic UI approach for making this work, but it's Semantic UI bound.

```{warning}
This is only possible when using your own escape hatch, and works only with SCSS-based themes, and not with SemanticUI themes, since it enables a couple of entry points that only support SCSS files.
This is only possible when using your own escape hatch, and works only with SCSS-based themes, and not with Semantic UI themes, since it enables a couple of entry points that only support SCSS files.
For an example of how it could be used, see: https://github.com/kitconcept/volto-light-theme
```

Expand Down
2 changes: 1 addition & 1 deletion docs/source/development/folder-structure.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Inside you can find the `theme.config` file that is used to set the theme
general settings.

The site customizations also should be located inside this folder following
[SemanticUI folder naming](https://github.com/Semantic-Org/Semantic-UI/tree/master/src/themes/default).
[Semantic UI folder naming](https://github.com/Semantic-Org/Semantic-UI/tree/master/src/themes/default).

* assets
* collections
Expand Down
2 changes: 1 addition & 1 deletion docs/source/release-notes/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -6987,7 +6987,7 @@ refer to all of them in https://github.com/plone/volto/releases
### Internal

- Added `forest.eea.europa.eu` as deployed Volto in production @tiberiuichim
- Add SemanticUI responsive variables to the responsive utils @sneridagh
- Add Semantic UI responsive variables to the responsive utils @sneridagh
- Added `yarnhook` to the build @sneridagh

## 4.0.0-alpha.36 (2020-02-03)
Expand Down
2 changes: 1 addition & 1 deletion docs/source/upgrade-guide/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -2110,7 +2110,7 @@ diffing the new ones with your versions.
### Testing lazy loaded components

The whole process has been designed to have a minimal impact in existing projects.
However, only one thing should be changed in your components tests, especially if your components are composed of original Volto components (not SemanticUI ones, though).
However, only one thing should be changed in your components tests, especially if your components are composed of original Volto components (not Semantic UI ones, though).

You should adapt them by mocking the Volto component or resolve (await) in an
async construction before the test is fired. See this Codepen example:
Expand Down
2 changes: 1 addition & 1 deletion packages/volto/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6987,7 +6987,7 @@ refer to all of them in https://github.com/plone/volto/releases
### Internal

- Added `forest.eea.europa.eu` as deployed Volto in production @tiberiuichim
- Add SemanticUI responsive variables to the responsive utils @sneridagh
- Add Semantic UI responsive variables to the responsive utils @sneridagh
- Added `yarnhook` to the build @sneridagh

## 4.0.0-alpha.36 (2020-02-03)
Expand Down
1 change: 1 addition & 0 deletions packages/volto/news/5855.documentation
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The proper name is Semantic UI. @stevepiercy

0 comments on commit 7bc30cb

Please sign in to comment.