Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS-6997: add brand_name and app_hash in create and get/list session response #340

Merged
merged 6 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
# Change Log
## [v4.68.2](https://github.com/plivo/plivo-node/tree/v4.68.2) (2024-09-06)
**Feature - Adding support for brand_name and app_hash in Create,Get and List Session**
- Added new request param `brand_name` and `app_hash` in create Session API
- Added support for `brand_name` and `app_hash` param in get and list Session response

## [v4.68.1](https://github.com/plivo/plivo-node/tree/v4.68.1) (2024-09-03)
**Feature - Adding new element for Audio Stream XML **
- Added `keepCallAlive` element in Audio Stream XML


## [v4.68.0](https://github.com/plivo/plivo-node/tree/v4.68.0) (2024-07-11)
**Feature - Locale param supported for Create, Get and List Verify Session API's**
- Added new request param `locale` in create Session API
Expand Down
14 changes: 13 additions & 1 deletion lib/resources/verify.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class SessionInterface extends PlivoResourceInterface {
create(sessionReq){

var isObject = arguments.length;
var app_uuid, recipient, url, method, channel, locale
var app_uuid, recipient, url, method, channel, locale , brand_name, app_hash , code_length

if (isObject === 1) {
app_uuid = sessionReq.app_uuid
Expand All @@ -149,6 +149,9 @@ export class SessionInterface extends PlivoResourceInterface {
method = sessionReq.method
channel = sessionReq.channel
locale = sessionReq.locale
brand_name = sessionReq.brand_name
app_hash = sessionReq.app_hash
code_length = sessionReq.code_length
}

let errors = validate([{
Expand Down Expand Up @@ -182,6 +185,15 @@ export class SessionInterface extends PlivoResourceInterface {
if(method) {
params.method = method
}
if(brand_name) {
params.brand_name = brand_name
}
if(app_hash) {
params.app_hash = app_hash
}
if (code_length) {
params.code_length = code_length
}
}

let client = this[clientKey];
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "plivo",
"version": "4.68.1",
"version": "4.68.2",
"description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
"homepage": "https://github.com/plivo/plivo-node",
"files": [
Expand Down
Loading