Merge pull request #285 from plivo/SMS-4946

SMS-4946/SMS-4848: adding new param 'is_domestic' in Get Message and List Message API
plivo · Mar 3, 2023 · 2259f77 · 2259f77
2 parents 2a6a279 + 3635614
commit 2259f77
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
 # Change Log
+## [4.41.0](https://github.com/plivo/plivo-node/tree/v4.41.0) (2023-03-03)
+**Adding new attribute - 'isDomestic' in Get Message and List Message APIs**
+- Add `isDomestic` to the response for the [list all messages API](https://www.plivo.com/docs/sms/api/message/list-all-messages/) and the [get message details API](https://www.plivo.com/docs/sms/api/message#retrieve-a-message)
+
 ## [4.40.0](https://github.com/plivo/plivo-node/tree/v4.40.0) (2023-02-23)
 **Feature - Enhance MDR filtering capabilities **
 - Added new fields on MDR object response

diff --git a/lib/resources/messages.js b/lib/resources/messages.js
@@ -49,6 +49,7 @@ export class MessageGetResponse {
         this.tendlcRegistrationStatus = params.tendlcRegistrationStatus;
         this.destinationCountryIso2 = params.destinationCountryIso2;
         this.requesterIP = params.requesterIp;
+        this.isDomestic = params.isDomestic;
     }
 }
 
@@ -72,6 +73,7 @@ export class MessageListResponse {
         this.tendlcRegistrationStatus = params.tendlcRegistrationStatus;
         this.destinationCountryIso2 = params.destinationCountryIso2;
         this.requesterIP = params.requesterIp;
+        this.isDomestic = params.isDomestic;
     }
 }
 

diff --git a/lib/rest/request-test.js b/lib/rest/request-test.js
@@ -1696,7 +1696,8 @@ export function Request(config) {
             total_amount: '0.00000',
             total_rate: '0.00350',
             units: 1,
-            requester_ip: "192.168.1.1"
+            requester_ip: "192.168.1.1", 
+            is_domestic: false
           }
         });
       }
@@ -1938,7 +1939,8 @@ export function Request(config) {
             total_amount: '0.00000',
             total_rate: '0.00350',
             units: 1,
-            requester_ip: '192.168.1.2'
+            requester_ip: '192.168.1.2', 
+            is_domestic: false
           }
         });
       }
@@ -1967,7 +1969,8 @@ export function Request(config) {
                 total_amount: '0.00000',
                 total_rate: '0.00350',
                 units: 1,
-                requester_ip: "192.168.1.1"
+                requester_ip: "192.168.1.1", 
+                is_domestic: false
               },
               {
                 error_code: '200',
@@ -1982,7 +1985,8 @@ export function Request(config) {
                 total_amount: '0.00000',
                 total_rate: '0.00350',
                 units: 1,
-                requester_ip: "192.168.1.2"
+                requester_ip: "192.168.1.2", 
+                is_domestic: false
               }
             ]
           }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plivo",
-  "version": "4.40.0",
+  "version": "4.41.0",
   "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
   "homepage": "https://github.com/plivo/plivo-node",
   "files": [

diff --git a/types/resources/messages.d.ts b/types/resources/messages.d.ts
@@ -22,6 +22,7 @@ export class MessageGetResponse {
 	units: string;
 	powerpackId: string;
 	requesterIp: string;
+	isDomestic: boolean;
 }
 export class MessageListResponse {
 	constructor(params: object);
@@ -39,6 +40,7 @@ export class MessageListResponse {
 	units: string;
 	powerpackId: string;
 	requesterIp: string;
+	isDomestic: boolean;
 }
 export class MMSMediaResponse {
 	constructor(params: object);