Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @metalsmith/permalinks to 2.5.1 #522

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Update @metalsmith/permalinks to 2.5.1 #522

merged 4 commits into from
Sep 27, 2023

Conversation

epreston
Copy link
Contributor

Updates the @metalsmith/permalinks plugin to 2.5.1

Adjusts metalsmith plugin order and adopts the replacement for the path attribute, permalinks.

Fixes: #521

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

        "@metalsmith/permalinks": "2.5.1",
        "node-fetch": "^3.3.2",
Adjust plugin order.  Add error checking.

See #521
Use permalink property which replaces path.

see: #521
build.mjs Outdated Show resolved Hide resolved
Remove commented code.
@willeastcott willeastcott merged commit 797201a into playcanvas:dev Sep 27, 2023
5 checks passed
@willeastcott
Copy link
Contributor

Wow, it's been a while since this repo had up to date dependencies. You're a life-saver, @epreston! 🙏

@willeastcott
Copy link
Contributor

Ooo, I think there might be a problem though. I just did a diff pre and post this PR:

image

This is the tutorial index page.

@epreston
Copy link
Contributor Author

I'll get onto that.

We might need to drop on of the 3rd party plugins for metalsmith that formats the final output. We could replace it with prettier for the same result. It hasn't gotten updates in 8 years and give security / dependency warnings.

@epreston
Copy link
Contributor Author

I think I know what to do there.

@epreston
Copy link
Contributor Author

Revert ? This might take an hour or two.

@willeastcott
Copy link
Contributor

It's fine. We don't have any deployments planned. 😄

@epreston
Copy link
Contributor Author

I did a winmerge compare after the fix. There are some differences but they all look like content differences.

@epreston epreston deleted the update-metalsmith-permalinks branch September 27, 2023 23:12
@epreston
Copy link
Contributor Author

Looks like the non English languages are getting duplicate navigation menus ?

willeastcott pushed a commit that referenced this pull request Sep 28, 2023
fix issue introduced in #522

The ordering of the plugins requires localization to run before tutorials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating to @metalsmith/[email protected] breaks the build
2 participants