Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#8248 COUNTER R5 TSV reports #373

Merged
merged 11 commits into from
Oct 15, 2024
Merged

pkp/pkp-lib#8248 COUNTER R5 TSV reports #373

merged 11 commits into from
Oct 15, 2024

Conversation

bozana
Copy link
Contributor

@bozana bozana commented Jul 1, 2024

@bozana bozana force-pushed the 9666 branch 5 times, most recently from 559f143 to e547af2 Compare August 26, 2024 13:35
@bozana
Copy link
Contributor Author

bozana commented Aug 27, 2024

Hi @jardakotesovec, I believe this is ready for your next review :-)
I think I have considered all suggestions from the first review round.
I have integrated your changes/commit for the customSubmit to work, and slightly adapted it in the next commit "adapt form".
And finally, why are the tests failing i.e. how should I proceed regarding them?
Thanks a lot!

Copy link
Collaborator

@jardakotesovec jardakotesovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major really.. but suggested couple of improvements.

Really appreciate willingness to familiarise with the composition api even its not completely necessary for this particular task. There is some getting used to - but it really gives lots of power for more complex UIs.

src/pages/counter/CounterReportsPage.vue Outdated Show resolved Hide resolved
@bozana
Copy link
Contributor Author

bozana commented Oct 8, 2024

Hi @jardakotesovec, I believe I have considered all your comments -- only one question is left -- so it is ready for the next review round :-)
Thanks a lot!

@bozana
Copy link
Contributor Author

bozana commented Oct 9, 2024

Hi @jardakotesovec, I have considered all your comments. Could you please have another look?
Thanks a lot!

Copy link
Collaborator

@jardakotesovec jardakotesovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple small suggestions, nothing major.

src/pages/counter/CounterReportsPage.vue Show resolved Hide resolved
src/pages/counter/CounterReportsPage.vue Outdated Show resolved Hide resolved
src/pages/counter/components/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/pages/counter/components/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
src/pages/counter/components/CounterReportsListPanel.vue Outdated Show resolved Hide resolved
@bozana
Copy link
Contributor Author

bozana commented Oct 14, 2024

Hi @jardakotesovec, I think I considered everything (in the last commit), could you please take another look?
Thanks a lot!

Copy link
Collaborator

@jardakotesovec jardakotesovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going along with composition api and other new things!

src/composables/useForm.js Outdated Show resolved Hide resolved
@bozana bozana merged commit 157a8cf into pkp:main Oct 15, 2024
5 checks passed
@bozana bozana deleted the 9666 branch October 15, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants