-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkp/pkp-lib#8248 COUNTER R5 TSV reports #373
Conversation
559f143
to
e547af2
Compare
Hi @jardakotesovec, I believe this is ready for your next review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major really.. but suggested couple of improvements.
Really appreciate willingness to familiarise with the composition api even its not completely necessary for this particular task. There is some getting used to - but it really gives lots of power for more complex UIs.
Hi @jardakotesovec, I believe I have considered all your comments -- only one question is left -- so it is ready for the next review round :-) |
Hi @jardakotesovec, I have considered all your comments. Could you please have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just couple small suggestions, nothing major.
Hi @jardakotesovec, I think I considered everything (in the last commit), could you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for going along with composition api and other new things!
s. pkp/pkp-lib#9666