Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web of Science Reviewer Recognition Service plugin for OJS 3.4 #301

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

Alex-nz
Copy link

@Alex-nz Alex-nz commented Aug 7, 2024

Add Web of Science Reviewer Recognition Service plugin for OJS 3.4 into the plugin gallery. This plugin is the heavily rebranded old Publons plugin, hence I put these together in the file.

@Alex-nz
Copy link
Author

Alex-nz commented Aug 8, 2024

Hi PKP team, can we please get this PR reviewed?

plugins.xml Show resolved Hide resolved
@Alex-nz
Copy link
Author

Alex-nz commented Sep 9, 2024

Hi @bozana , we've made the requested updates and updated the PR, can you please re-review?

I think should be used below.

^ I've used the same certification type that we were given when published the plugin previously, under Publons name. I have updated it to "reviewed" as you suggested.

@bozana
Copy link

bozana commented Sep 10, 2024

Hi @Alex-nz,
I would have two more comments:

  • I think in the function exportReview it should be also checked that the $request->getContext()->getId() is the same as the submission->getData('contextId')
  • Why are you using https://fonts.googleapis.com/css?family=Roboto? -- We have chosen the fonts under consideration to support wide range of languages etc. They are downloaded and provided with OJS. So plugins would preferably use them (you would not need to do anything for that).
    This way, using 'https://fonts.googleapis.com/css?family=Roboto' would provide user information (IP) address to google (which would be good to inform/ask the user about). Thus, if you would really need that CSS, maybe to download it and provide it within the plugin, but I believe there should be no need to use anything extra.

And finally, let me double check regarding the certification level with the team...

Thanks a lot!

@bozana
Copy link

bozana commented Sep 10, 2024

I have forgotten to include @v0k1c into my comment above :-( Sorry! But now... :-)

@Alex-nz
Copy link
Author

Alex-nz commented Sep 10, 2024

thank you @bozana , @v0k1c and I are looking into your comments.

@Alex-nz
Copy link
Author

Alex-nz commented Sep 17, 2024

@bozana, @v0k1c has made the changes as requested and I've updated this PR to reflect the new release. Can you please re-review?

@v0k1c
Copy link

v0k1c commented Sep 18, 2024

Hi @bozana! I've just double checked, and Open Sans (although available within the theme plugin?) is not loaded by default? All I'm seeing that is loaded is Noto Sans and Fontawesome. Would it be safe to import/enable it through theme plugin, or what is the preferred way to use additional fonts that are available there? Asking because I can't find anything related to this within the available documentation. #edit - adding @Alex-nz to the reply..

@bozana
Copy link

bozana commented Sep 23, 2024

Hi @Alex-nz and @v0k1c, I will take a new look at the code, and will forward your question about the fonts to @jardakotesovec :-)
Thanks a lot!

@bozana
Copy link

bozana commented Sep 24, 2024

Hi @Alex-nz and @v0k1c, the code now looks good, no further comments :-)
I also double checked with the team that certification level = "reviewed" is good.
Lets just wait what @jardakotesovec says about the fonts and then we can merge.
Thanks a lot for the great work/contribution!

@Alex-nz
Copy link
Author

Alex-nz commented Oct 1, 2024

@bozana , @jardakotesovec, could we please get the direction for how to proceed with fonts here? We have customers waiting to start using the plugin.

@jardakotesovec
Copy link

@v0k1c My understanding is that this plugin renders UI only on editorial side of OJS, after reviewer completes the review, right?

On Editorial site we use noto-sans, I would recommend just to use that, so we don't increase the resources that needs to be fetched unnecessarily.

Themes utilise various fonts, but these are specific only for 'reader side'. On editorial side we don't intend provide flexibility on theming or use of different fonts.

Does that answer the question?

@Alex-nz
Copy link
Author

Alex-nz commented Oct 3, 2024

thanks @jardakotesovec , yes, you have answered the question.
@v0k1c has updated the plugin accordingly
@bozana can you please re-review and merge if all well?

@bozana bozana merged commit 14cf2f6 into pkp:main Oct 7, 2024
1 check passed
@bozana
Copy link

bozana commented Oct 7, 2024

Thanks a lot all! Merged 🎉

@Alex-nz
Copy link
Author

Alex-nz commented Oct 8, 2024

Great, thank you very much everyone involved!

@Alex-nz
Copy link
Author

Alex-nz commented Oct 9, 2024

@bozana can you please confirm when is this plugin going to be available within the gallery? I have a local installation of OJS 3.4.0.4 which I used for testing the plugin, but I don't see it in the plugin gallery list.

@bozana
Copy link

bozana commented Oct 9, 2024

Hi @Alex-nz, I can see it now in my local 3.4 installation... Do you see it now?

@Alex-nz
Copy link
Author

Alex-nz commented Oct 10, 2024

@bozana Yes, I can see it today, but for some reason it wasn't present there yesterday. Anyways, it's all good then, thank you.

@bozana
Copy link

bozana commented Oct 24, 2024

Hi @Alex-nz and @v0k1c, may I ask you here a question -- I cannot find anything online:
We are thinking how to integrate OJS with ResearcherID: Would it be possible for OJS users to, similarly to ORCID, add their authenticated/verified (and not just manually entered) ResearcherID to their OJS profile? -- I cannot find any API endpoint that would allow this kind of authentication and retrieval of user's Web of Science ResearcherID. Could you maybe help me?
And, if we would work on other kind of integration with Clarivate products, what would be best way to ask question, would it be possible to get test accounts, etc.
If you want you can also answer me per e-mail: bozana dot bokan at posteo dot net.
I would be very happy about any further information.
Thanks a lot!

@Alex-nz
Copy link
Author

Alex-nz commented Oct 29, 2024

hi @bozana, sorry for a delayed response: I was on vacation and only returned today. I've emailed you.

@bozana
Copy link

bozana commented Oct 29, 2024

Thanks a lot @Alex-nz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants