New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/plagiarism#52 Plugin update with new iThenticate API integration #64

Merged

touhidurabir merged 16 commits into pkp:stable-3_4_0 from touhidurabir:i52_stable_3_4_0

Sep 30, 2024

Member

touhidurabir commented Sep 10, 2024 •

edited

Loading

for #52

This PR make the plugin compatible with OJS/OMP/OPS stable-3.4.0-6 .


          pkp#52 Plugin update with new iThenticate API integration

618f641

Member Author

touhidurabir commented Sep 10, 2024 •

edited

Loading

@asmecher Please take a look at this PR . I have added the EULA confirmation at the final stage submission review section as below

There is some small tweak lefts but good enough to take first look .

Also the compatibility testing with OMP and OPS stable-3.4.0 is still needed to be done .

asmecher reviewed

View reviewed changes

PlagiarismSubmissionSubmitListener.php Outdated

		@@ -3,8 +3,8 @@
		/**
		* @file plugins/generic/plagiarism/PlagiarismSubmissionSubmitListener.php

Member

asmecher Sep 10, 2024

Looking at the diff, this file appears to have DOS line endings; please convert over to UNIX-style.

asmecher reviewed

View reviewed changes

TestIthenticate.php Outdated Show resolved Hide resolved

asmecher reviewed

View reviewed changes

controllers/PlagiarismArticleGalleyGridHandler.php Outdated Show resolved Hide resolved

asmecher reviewed

View reviewed changes

controllers/PlagiarismComponentHandler.php Outdated Show resolved Hide resolved

asmecher reviewed

View reviewed changes

controllers/PlagiarismIthenticateActionHandler.php Outdated Show resolved Hide resolved

asmecher reviewed

View reviewed changes

controllers/PlagiarismWebhookHandler.php Outdated Show resolved Hide resolved

asmecher reviewed

View reviewed changes

grids/RearrangeColumnsFeature.php Outdated Show resolved Hide resolved

asmecher reviewed

View reviewed changes

grids/SimilarityActionGridColumn.php Outdated Show resolved Hide resolved

asmecher reviewed

View reviewed changes

templates/similarityScore.tpl Outdated Show resolved Hide resolved

asmecher reviewed

View reviewed changes

tools/registerWebhooks.php Show resolved Hide resolved

Member

asmecher commented Sep 10, 2024

Thanks, @touhidurabir, I looked over a diff between the 3.3.x and proposed 3.4.x implementations and it looks clean. I didn't test it, though -- let's walk through that when you're ready.

touhidurabir added 7 commits

September 11, 2024 10:59


          pkp#52 code clean up

d1125ab


          pkp#52 bring back eula confirm template that deleted mistakenly

bb2b49f


          pkp#52 stable-3.4.0 OPS compatibility changes applied

f07b264


          pkp#52 stable-3.4.0 removed use of import method

dbd714d


          pkp#52 stable-3.4.0 added component instance override on LoadComponen…

158420b

…tHandler hook call


          pkp#52 stable-3.4.0 fixed component instance override on LoadComponen…

6d79e4c

…tHandler hook call for OPS


          pkp#52 stable-3.4.0 removed unnecessary doc blocks

ec1e5a2

Member Author

touhidurabir commented Sep 13, 2024

@asmecher all updated and tested for OMP and OPS, seems working fine . should ready for a final look or better, if we can have a test instance for 3.4.0 to test it .

Member

asmecher commented Sep 13, 2024

👍 I've asked in Mattermost -- thanks, @touhidurabir!

touhidurabir added 8 commits

September 18, 2024 13:42


          pkp#52 stable-3.4.0 added error log if ithenticate creating submissio…

5c5f841

…n failed


          pkp#52 stable-3.4.0 moved default eula lang details under the checkin…

aef2cd1

…g of eula required and validation passes


          pkp#52 stable-3.4.0 removed user requirement on submission submit eve…

8943d6e

…nt listener


          pkp#52 stable-3.4.0 refactor applicable locale determining code

9abc03c


          pkp#52 stable-3.4.0 better handling of EULA lang, caching and multi l…

da8f6fc

…ang file name


          pkp#52 stable-3.4.0 set ithenticateSubmissionCompletedAt only when do…

aac8735

…ne ithenticate check at submission time


          pkp#52 stable-3.4.0 fixing calling non static prop as static

e8e3f3e


          pkp#52 stable-3.4.0 filter the available locales for submission

27f9386

touhidurabir merged commit c768331 into pkp:stable-3_4_0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet