Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert controlled vocabulary classes to Eloquent models #10292

Open
asmecher opened this issue Aug 8, 2024 · 1 comment
Open

Convert controlled vocabulary classes to Eloquent models #10292

asmecher opened this issue Aug 8, 2024 · 1 comment
Assignees
@touhidurabir
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5.0 LTS

Comments

@asmecher
Copy link
Member

asmecher commented Aug 8, 2024 •
edited by touhidurabir
Loading

There are several classes that use the old DAO storage model to handle controlled vocabularies and related code:

  • controlled_vocab_entries and controlled_vocab_entry_settings (these will require a trait for settings tables, which @Vitaliy-1 is working on)
  • controlled_vocabs
  • user_interests

In preparation for extensions to the controlled vocabulary toolset in support of vocabulary plugins that implement specific vocabs (e.g. LCSH etc), the storage model for these tables should be migrated to Eloquent.

PRs
pkp-lib --> #10324
ojs --> pkp/ojs#4403
omp --> pkp/omp#1722
ops --> pkp/ops#788
citationStyleLanguage --> pkp/citationStyleLanguage#127
jatsTemplate --> pkp/jatsTemplate#54
oaiJats --> pkp/oaiJats#51
reviewReport --> pkp/reviewReport#52
@asmecher asmecher added this to the 3.5.0 LTS milestone Aug 8, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 16, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
e9c27fc
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
9375230
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
852c673
This was referenced Aug 16, 2024
Open
Open
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 16, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
d1e3e38
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
85bf407
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
a9d82cd
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
ae25aff
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 19, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
a581dc9
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
5db03d3
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
09dbd87
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 19, 2024
@touhidurabir
pkp#10292 typo fixed
12072a7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
2055e6d
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 proper model import for native xml
5cefa04
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
20fefd2
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
dd868ac
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
8b5d705
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 typo fixed
15f9263
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 proper model import for native xml
4845517
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
ff4e8f7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
80cd267
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
22f3d1c
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
a8b8438
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 added user_interests primary key migration
c40165b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 fixed user_interests primary key migration path
46d784e
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 fixing unit tests
1463f2d
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
c517c8b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Oct 22, 2024
@touhidurabir
pkp/pkp-lib#10292 refactored entry dao to model class
bed0d17
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Oct 22, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
605e238
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Oct 22, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
f8c8439
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Oct 22, 2024
@touhidurabir
pkp/pkp-lib#10292 removed setting_type column
c7e462e
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Oct 22, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
2ad3f9a
@touhidurabir touhidurabir mentioned this issue Oct 22, 2024
Open
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Oct 22, 2024
@Vitaliy-1
pkp#10292 Fix update setting values for a Model
af13289
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 fixed issue the data building with settings attrs
fb50a00
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
54bf6b4
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
e4d5ee3
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 typo fixed
ed09b59
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 proper model import for native xml
e5b161c
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 fixing unit tests
55f43a9
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 Refactored user interest to model and repository
5e2c9f3
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 removed extended vocab classes
e924fc3
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 fixing issue with vocab storing and some doc blocks added
dd5959d
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 added TODO to investigate the impact of merged issue pkp#10423
2a0a379 
 PR
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 refactored entry dao to model class
9ad4168
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 removed setting_type column
b321612
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 fixed vocab setting issue
a827948
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 refactored interest manager to repo and removed it
f192d62
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 resolved all but one TODO
6642ae9
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 fixed issue the settings builder to retrieve specific colum…
c89621a 
…ns only
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 added ability to add setting and multilingual column value …
ce24986 
…on update
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 fixed issue when guarded attribute defined
f12139c
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 updated implementation of updating with multilingual data
c4644ba
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 added multilingual casting as part of pkp#10476
b9d8651
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Oct 23, 2024
@touhidurabir
pkp#10292 fixed issue the data building with settings attrs
6c94c9d
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Oct 23, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
8177140
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Oct 30, 2024
@Vitaliy-1
pkp#10292 Fix update setting values for a Model
7488b20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
2 participants
@asmecher @touhidurabir