Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentangle block "symbolic name" from title #17

Open
asmecher opened this issue Mar 15, 2017 · 2 comments
Open

Disentangle block "symbolic name" from title #17

asmecher opened this issue Mar 15, 2017 · 2 comments

Comments

@asmecher
Copy link
Member

See http://forum.pkp.sfu.ca/t/ojs3-display-custom-block-name-option/29154/2.

Currently the "block name" field is used...

  • As a column in the grid row
  • As a symbolic name in the back-end (e.g. plugin name in plugin_settings)

It is currently limited to alphanumerics, as it's symbolic.

Suggested:

  • Have the symbolic name auto-generated (using e.g. uniqid) and not presented to the user anywhere.
  • Make the current "block title" field a proper title field, not limited to alphanumeric characters. Use this for the grid column, and have it display as a block title when the block is displayed.
  • Keep the block title optional, in case users want a block e.g. with image-only content.
@asmecher asmecher changed the title Disentanble block "symbolic name" from title Disentangle block "symbolic name" from title Mar 15, 2017
asmecher added a commit to pkp/pkp-lib that referenced this issue Sep 11, 2019
asmecher added a commit to pkp/pkp-lib that referenced this issue Sep 11, 2019
@asmecher
Copy link
Member Author

The above commits (identical but applied to different branches) allow the editing/deletion of blocks that have already been created (e.g. in OJS 2.x) with spaces in their names. The other issues listed above are not yet addressed.

@jonasraoni
Copy link
Contributor

I was taking a look at this plugin, and the implementation has the potential to generate unexpected conflicts, on the screenshot I created an item using the name "crossrefplugin" (as it adds an enabled = 1 to the settings, it can be used to enable plugins):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants