Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the race condition during create initial connection #64

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix the race condition during create initial connection #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/renderer/lib/k8s-port-forwarding-patch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,13 @@ WebSocketHandler.restartableHandleStandardInput = async function (createWS, stdi

// It's important to open connection immediately (even without data) for some apps (for example: mariadb)
try {
ws = await createWS()
let initialWS = await createWS()
if (!ws) {
ws = initialWS
} else {
// Connection has already been created in processData, so it should not be overwritten.
initialWS.close()
}
} catch (e) {
console.error(e)
}
Expand Down