Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plenticore.js #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update plenticore.js #28

wants to merge 1 commit into from

Conversation

psg1
Copy link

@psg1 psg1 commented Feb 4, 2021

Erweiterung des devicePort

Erweiterung des devicePort
@StrathCole
Copy link
Contributor

Thanks for contributing. I think there has to be a check for validity of the port here and also in #27 to avoid errors.

Valid ports should be 1 to 65535 with fallback to default 80 on invalid setting.

@StrathCole StrathCole mentioned this pull request Feb 4, 2021
@psg1
Copy link
Author

psg1 commented Feb 4, 2021

<input type="number" min="1" max=""65535" />

im plenticore.js kann man ja eine
if(devicePort<1 || devicePort>65535) {
devicePort = 80;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants