Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC6062 TURN TCP allocations #148

Closed
wants to merge 4 commits into from
Closed

RFC6062 TURN TCP allocations #148

wants to merge 4 commits into from

Conversation

seankhliao
Copy link

Description

Implements both client and server side support for TCP allocations and connections to peers.

Things to do:

  • tests, what to test?
  • add example(s)
  • review/break out use of syscalls for port reuse
  • review double lookup internal/server/turn.go

Reference issue

Fixes #143, #118

@seankhliao seankhliao requested a review from Sean-Der July 29, 2020 21:54
@GingerAdonis
Copy link

GingerAdonis commented Jul 30, 2020

Great to see you've implemented TCP support! I'll definitely test this within a couple of weeks.

Edit: Oh wait. I thought seankhliao was Sean from reddit. But that's Sean-Der. Anyways, great work! 👍

@Sean-Der
Copy link
Member

Sean-Der commented Aug 2, 2020

This is amazing! Nice work @seankhliao I am reviewing now :)

I don't have access to a computer for another day or two so will be slower then usual sorry :(

@kylecarbs
Copy link
Member

@Sean-Der is there anything I can do to help this get merged? 🙌

@GingerAdonis
Copy link

@Sean-Der Did you get around testing these changes?

@GingerAdonis
Copy link

Bump. This is a highly useful PR.

@seankhliao
Copy link
Author

I'm going to close this as:

  1. I've lost all context for this
  2. the underlying codebase seems to changed quite a bit

If anyone wants to work on this, feel free to base it off this code (if it's still useful)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

RFC6062 implementation
4 participants