Misc cleanups after rebase

client.go

@@ -511,7 +511,7 @@ func (c *Client) handleSTUNMessage(data []byte, from net.Addr) error {
 			allocation := c.getTCPAllocation()
 			if allocation == nil {
 				c.log.Debug("no TCP allocation exists")
-				return nil // silently discard
+				return nil // Silently discard
 			}
 
 			allocation.HandleConnectionAttempt(addr, cid)

examples/turn-client/tcp_alloc/main.go → examples/turn-client/tcp-alloc/main.go

@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
+// SPDX-License-Identifier: MIT
+
 // Package main implements a TURN client with support for TCP
 package main
 

internal/client/allocation.go

@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
+// SPDX-License-Identifier: MIT
+
 package client
 
 import (
@@ -20,16 +23,15 @@ type AllocationConfig struct {
 }
 
 type Allocation struct {
-	client            Client                // read-only
-	relayedAddr       net.Addr              // read-only
-	permMap           *permissionMap        // thread-safe
-	bindingMgr        *bindingManager       // Thread-safe
-	integrity         stun.MessageIntegrity // read-only
-	_nonce            stun.Nonce            // needs mutex x
-	_lifetime         time.Duration         // needs mutex x
-	refreshAllocTimer *PeriodicTimer        // thread-safe
-	refreshPermsTimer *PeriodicTimer        // thread-safe
-	readTimer         *time.Timer           // thread-safe
-	mutex             sync.RWMutex          // thread-safe
-	log               logging.LeveledLogger // read-only
+	client            Client                // Read-only
+	relayedAddr       net.Addr              // Read-only
+	permMap           *permissionMap        // Thread-safe
+	integrity         stun.MessageIntegrity // Read-only
+	_nonce            stun.Nonce            // Needs mutex x
+	_lifetime         time.Duration         // Needs mutex x
+	refreshAllocTimer *PeriodicTimer        // Thread-safe
+	refreshPermsTimer *PeriodicTimer        // Thread-safe
+	readTimer         *time.Timer           // Thread-safe
+	mutex             sync.RWMutex          // Thread-safe
+	log               logging.LeveledLogger // Read-only
 }

internal/client/client.go

@@ -1,3 +1,7 @@
+// SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
+// SPDX-License-Identifier: MIT
+
+// Package client implements the API for a TURN client
 package client
 
 import (

internal/client/tcp_alloc.go

@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
+// SPDX-License-Identifier: MIT
+
 package client
 
 import (

internal/client/tcp_conn.go

@@ -1,4 +1,6 @@
-// Package client implements the API for a TURN client
+// SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
+// SPDX-License-Identifier: MIT
+
 package client
 
 import (

internal/client/tcp_conn_test.go

@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
+// SPDX-License-Identifier: MIT
+
 package client
 
 import (

internal/client/udp_conn.go

@@ -33,11 +33,11 @@ type inboundData struct {
 }
 
 // UDPConn is the implementation of the Conn and PacketConn interfaces for UDP network connections.
-// comatible with net.PacketConn and net.Conn
+// compatible with net.PacketConn and net.Conn
 type UDPConn struct {
-	bindingMgr *bindingManager   // thread-safe
-	readCh     chan *inboundData // thread-safe
-	closeCh    chan struct{}     // thread-safe
+	bindingMgr *bindingManager   // Thread-safe
+	readCh     chan *inboundData // Thread-safe
+	closeCh    chan struct{}     // Thread-safe
 	Allocation
 }
 
@@ -203,7 +203,7 @@ func (c *UDPConn) WriteTo(p []byte, addr net.Addr) (int, error) { //nolint: goco
 			}
 		}()
 
-		// send data using SendIndication
+		// Send data using SendIndication
 		peerAddr := addr2PeerAddress(addr)
 		var msg *stun.Message
 		msg, err = stun.Build(
@@ -381,7 +381,7 @@ func (c *Allocation) CreatePermissions(addrs ...net.Addr) error {
 
 // HandleInbound passes inbound data in UDPConn
 func (c *UDPConn) HandleInbound(data []byte, from net.Addr) {
-	// copy data
+	// Copy data
 	copied := make([]byte, len(data))
 	copy(copied, data)
 

internal/ipnet/util.go

@@ -49,5 +49,5 @@ func FingerprintAddr(addr net.Addr) string {
 	case *net.TCPAddr: // Do we really need this case?
 		return a.IP.String()
 	}
-	return "" // should never happen
+	return "" // Should never happen
 }

internal/proto/fuzz_test.go

@@ -63,28 +63,28 @@ func FuzzSetters(f *testing.F) {
 		m1.Add(attr.t, value)
 		if err := attr.g.GetFrom(m1); err != nil {
 			if errors.Is(err, stun.ErrAttributeNotFound) {
-				fmt.Println("unexpected 404") // nolint
-				panic(err)                    // nolint
+				fmt.Println("unexpected 404") //nolint
+				panic(err)                    //nolint
 			}
 			return
 		}
 
 		m2.WriteHeader()
 		if err := attr.g.AddTo(m2); err != nil {
-			fmt.Println("failed to add attribute to m2") // nolint
-			panic(err)                                   // nolint
+			fmt.Println("failed to add attribute to m2") //nolint
+			panic(err)                                   //nolint
 		}
 
 		m3.WriteHeader()
 		v, err := m2.Get(attr.t)
 		if err != nil {
-			panic(err) // nolint
+			panic(err) //nolint
 		}
 		m3.Add(attr.t, v)
 
 		if !m2.Equal(m3) {
-			fmt.Println(m2, "not equal", m3) // nolint
-			panic("not equal")               // nolint
+			fmt.Println(m2, "not equal", m3) //nolint
+			panic("not equal")               //nolint
 		}
 	})
 }

internal/server/turn.go

@@ -131,7 +131,8 @@ func handleAllocateRequest(r Request, m *stun.Message) error {
 	}
 
 	// Once the allocation is created, the server replies with a success
-	// response.  The success response contains:
+	// response.
+	// The success response contains:
 	//   * An XOR-RELAYED-ADDRESS attribute containing the relayed transport
 	//     address.
 	//   * A LIFETIME attribute containing the current value of the time-to-