-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I1083 l bfgs optimiser #1149
Draft
alisterde
wants to merge
17
commits into
main
Choose a base branch
from
i1083_l-bfgs_optimiser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
I1083 l bfgs optimiser #1149
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7e36b83
abstract class LineSearchBasedOptimiser
ab50fa8
:construction: lbfgs algorithm
a350cb6
Removing none ASCII characters
6d71df4
:fire:
635acc3
removing non ASCII characters
7ea50f4
LBFGS ready for sepration into abstract class
3985888
deleting bfgs_scipy
ec2b7c7
seperating linsearch
ef4de15
renaming bfgs to lbfgs
e1b3585
splitting optimser and linesearch
3c0244b
documentation related to LBFGS and linesearch
009e7be
Delete bfgs_trial.ipynb
alisterde 1d94914
Merge branch 'i1083_l-bfgs_optimiser' of https://github.com/pints-tea…
683a2a5
Adding convergence stopping crtirea to lbfgs
858857f
lbfgs example (needs improving)
10c8f35
style fix
4369b39
Adding lbfgs notebook to documentation
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure this is the best way to do it yet, but let's leave all that till after we have a working prototype!