Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox in cluster forms for when the cluster is managed #1732

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

gzpcho
Copy link
Contributor

@gzpcho gzpcho commented Oct 17, 2024

Forms when cluster is managed

image
image
image
image

@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Oct 17, 2024
@robbintt
Copy link
Contributor

Could the checkbox go into a div appropriate with for the rest of the form contents, and maybe go in a vertical form width
stack above the submit button so it is much more prominent?

@robbintt
Copy link
Contributor

Also I think the checkbox should have a description like "Disable Mangement", then the long language would be a tooltip or a italicized small font description on the following line?

@robbintt
Copy link
Contributor

I think it would better not to ship the form partially disabled --

What do you think about:

  1. ask the team if there is a straightforwards vue way to disable
  • (we can sacrifice the active approach to allowing changes to the form, e.g. the checkbox would need to be submitted via the button, then the form reloads and it is editable.)
  1. hide any fields that can't be disabled, so they are invisible, then solve the hiding as a followup after the project is ready.

@gzpcho gzpcho force-pushed the iroquebert/iac-flag-in-cluster-form branch 2 times, most recently from 4e13207 to 16fae9e Compare October 17, 2024 23:54
@gzpcho gzpcho force-pushed the iroquebert/iac-flag-in-cluster-form branch from 16fae9e to 368d6ec Compare October 18, 2024 00:11
@gzpcho
Copy link
Contributor Author

gzpcho commented Oct 18, 2024

Could the checkbox go into a div appropriate with for the rest of the form contents, and maybe go in a vertical form width stack above the submit button so it is much more prominent?

Also I think the checkbox should have a description like "Disable Mangement", then the long language would be a tooltip or a italicized small font description on the following line?

Addressed on 368d6ec

@gzpcho gzpcho force-pushed the iroquebert/iac-flag-in-cluster-form branch 3 times, most recently from 37afff0 to 368d6ec Compare October 18, 2024 18:17
@gzpcho gzpcho force-pushed the iroquebert/iac-flag-in-cluster-form branch from 3514bd7 to c84bb33 Compare October 18, 2024 18:28
@gzpcho
Copy link
Contributor Author

gzpcho commented Oct 18, 2024

Was able to completely disable the form on c84bb33

@gzpcho gzpcho marked this pull request as ready for review October 18, 2024 19:05
@gzpcho gzpcho requested a review from a team as a code owner October 18, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-board Includes changes to deploy-board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants