PopoverEducational: Add Experimental Prop for Notification (background color change) #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -137,6 +142,7 @@ export default function PopoverEducational({ | |||
| shouldFocus = false, | |||
| size = 'sm', | |||
| zIndex, | |||
| _experimentalVariant, | |||
There was a problem hiding this comment.
super nit: let's set the default to 'education'
|
We need to fix Text |
AlbertCarreras
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an experimental prop to the component PopoverEducational so we can test out using it for notification purposes on web. This simply changes the background color of the current component.
light mode
dark mode
Approved contribution doc: https://docs.google.com/document/d/1uhpW2DmYsMWXMba0J0xkJrUyg8YnPrUdLTyNN2eergs/edit
What changed?
Added prop: _experimentalVariant?: 'notification' | 'education'
If _experimentalVariant set to 'notification', set bgColor to be 'darkGray', otherwise default to 'blue'.
Why?
In August 2024, the Social Growth team shipped this experiment to show users a notification message on dWeb app start if they have unread messages and saw overall success on messaging engagement. At that time, we used a component that is not standard to Gestalt. For a long term solution, it would be ideal if we could have a standardized Gestalt component for use cases like this.
Links